Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter validation for AssumeRole and AssumeRoleWithWebIdentity #277

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

gdavison
Copy link
Contributor

The AssumeRole and AssumeRoleWithWebIdentity operations fail silently if the required parameter RoleARN is not set. With AssumeRole, this means that the source credentials will be returned.

Now returns an error when required parameters are not set.

Relates hashicorp/terraform-provider-aws#24796

@gdavison gdavison requested a review from a team as a code owner May 17, 2022 17:15
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok  	github.com/hashicorp/aws-sdk-go-base/v2	2.121s

@gdavison gdavison merged commit 7d8aac5 into main Jun 6, 2022
@gdavison gdavison deleted the assume-role-validation branch June 6, 2022 17:59
gdavison added a commit that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants