Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AWS Region, eu-south-2 #337

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Add new AWS Region, eu-south-2 #337

merged 2 commits into from
Nov 16, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 16, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #336.

% go test ./...
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.712s
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	0.775s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	(cached)
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	(cached)

@ewbankkit ewbankkit requested a review from a team as a code owner November 16, 2022 13:27
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ go test -count=1 ./...
ok      github.com/hashicorp/aws-sdk-go-base/v2 0.994s
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig      [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/constants      [no test files]
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints      0.135s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/expand 0.201s
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/test   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/mockdata        [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/servicemocks    [no test files]
ok      github.com/hashicorp/aws-sdk-go-base/v2/useragent       0.295s

@ewbankkit ewbankkit merged commit 65d7b99 into main Nov 16, 2022
@ewbankkit ewbankkit deleted the f-add-eu-south-2 branch November 16, 2022 14:08
ewbankkit added a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new eu-south-2 AWS Region to internal/endpoints/endpoints.go
2 participants