Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable HTTP client #340

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Configurable HTTP client #340

merged 2 commits into from
Jan 13, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 5, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #323.

  • Adds an http.Client property to the Config object which is used as a custom HTTP client for both AWS SDK v1 and SDKv2 APIs. If the configured property value is nil then a per-SDK-version default HTTP client is used.
  • Adds the Client.HTTPTransportOptions function which returns functional options to configure an http.Transport with the settings specified in the Config. These options are used for both AWS SDK v1 and SDK v2 default HTTP clients and should be used by any configured custom HTTP client.

@ewbankkit ewbankkit requested a review from a team as a code owner December 5, 2022 16:54
gdavison
gdavison approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ewbankkit ewbankkit mentioned this pull request Jan 5, 2023
Merged
@ewbankkit ewbankkit merged commit 554bd94 into main Jan 13, 2023
@ewbankkit ewbankkit deleted the f-configurable-http-client branch January 13, 2023 19:09
ewbankkit added a commit that referenced this pull request Jan 13, 2023
@ewbankkit
Add Update CHANGELOG for #340.
caee5a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting of HTTP Transport
2 participants
@ewbankkit @gdavison