V2: Make Assume Role config a separate struct #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewbankkit
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
LGTM 🚀.
% make test
go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2 6.326s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 0.717s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr 0.525s
% make golangci-lint
cd v2/awsv1shim && golangci-lint run ./...
ewbankkit
reviewed
Sep 23, 2021
GNUmakefile
Outdated
| @@ -7,6 +7,7 @@ lint: golangci-lint importlint | |||
|
|
|||
| golangci-lint: | |||
| @golangci-lint run ./... | |||
| cd v2/awsv1shim && golangci-lint run ./... | |||
There was a problem hiding this comment.
Add @ here or remove from above to keep consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the assume role configuration a separate struct instead of inline