Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back INI parsing for trailing # error #787

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

gdavison
Copy link
Contributor

Trailing # are stripped from values in AWS shared config files.

Roll back github.com/aws/aws-sdk-go-v2/internal/ini and github.com/aws/aws-sdk-go-v2/config

Adds additional test for file parsing

@gdavison gdavison requested a review from a team as a code owner November 16, 2023 01:48
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gdavison gdavison merged commit ac073f9 into main Nov 16, 2023
12 checks passed
@gdavison gdavison deleted the more-config-file-parsing-tests branch November 16, 2023 02:16
gdavison added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants