Enable FIPS and DualStack endpoint configuration #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewbankkit
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make test
go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.16.0
ok github.com/hashicorp/aws-sdk-go-base/v2 6.591s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/httpclient [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go v1.42.41
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 5.997s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr 0.784s
YakDriver
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Not that you need a second opinion but looks great! 🎉
% go test ./...
go: downloading github.com/aws/aws-sdk-go-v2/credentials v1.8.0
go: downloading github.com/aws/aws-sdk-go-v2/config v1.13.0
go: downloading github.com/aws/aws-sdk-go-v2 v1.13.0
go: downloading github.com/aws/smithy-go v1.10.0
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.10.0
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.16.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.14.0
go: downloading github.com/google/go-cmp v0.5.7
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.7.0
go: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.3.4
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.9.0
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.4
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.2.0
ok github.com/hashicorp/aws-sdk-go-base/v2 5.974s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/httpclient [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go v1.42.41
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 5.645s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr 0.737s| UseDualStackEndpoint: true, | ||
| }, | ||
| SharedConfigurationFile: ` | ||
| [default] |
There was a problem hiding this comment.
Love these test cases for all the different ways 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2021-11-06 Release of the AWS SDK for Go v2 and the AWS SDK for Go v1.42.0 add support for configuring FIPS and DualStack API endpoints using environment variables, the shared configuration file, and programmatically.
This PR adds configuration parameters to
awsbase.Configand passes FIPS and DualStack configuration to the AWS SDK v1 shim layer