Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent aws-sdk-go-v2 retryers #918

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Independent aws-sdk-go-v2 retryers #918

merged 2 commits into from
Feb 14, 2024

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #915.
Relates hashicorp/terraform-provider-aws#34669.

Ensures that each call to aws.Config.Retryer() (which happens once per AWS service client) is truly independent, in particular the token bucket for throttling errors is per-service.

@ewbankkit ewbankkit requested a review from a team as a code owner February 13, 2024 22:36
@gdavison gdavison self-assigned this Feb 13, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ewbankkit
Copy link
Contributor Author

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	5.565s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	(cached)
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	(cached)

@ewbankkit
Copy link
Contributor Author

@dependabot rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared AWS SDK for Go v2 Retryer leading to increased QuotaExceededException API throttling errors
2 participants