clean up, setting maintaining team to Consul #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roncodingenthusiast
commented
Aug 9, 2023
•
roncodingenthusiast
commented
- setup golangci lint
- updates to slack and notification channels
- adding a make command for linting
roncodingenthusiast
force-pushed
the
issue-1767
branch
from
7962ec5
to
24e8f2e
Compare
roncodingenthusiast
force-pushed
the
issue-1767
branch
2 times, most recently
from
345188b
to
98c27f8
Compare
roncodingenthusiast
requested review from
dekimsey and
jeanneryan
and removed request for
a team
roncodingenthusiast
force-pushed
the
issue-1767
branch
from
5b81a52
to
31d5eaf
Compare
roncodingenthusiast
requested review from
steshageo
and removed request for
a team
- clean up dependencies - adding golangci lint - updating maintaining teams - allow release/** to build newer versions of consul-template going forward
roncodingenthusiast
force-pushed
the
issue-1767
branch
from
31d5eaf
to
ec80694
Compare
kisunji
approved these changes
Oct 4, 2023
johnlanda
reviewed
Oct 4, 2023
| release_branches = ["main"] | ||
| release_branches = [ | ||
| "main", | ||
| "release/**", |
There was a problem hiding this comment.
What is the effect of adding the release/** here?
| @@ -72,3 +72,9 @@ toc: | |||
| dev-tree: | |||
| @true | |||
| .PHONY: dev-tree | |||
|
|
|||
| # lint | |||
| lint: | |||
| @@ -68,7 +68,3 @@ require ( | |||
| golang.org/x/time v0.3.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/golang/lint => golang.org/x/lint v0.0.0-20190409202823-959b441ac422 | |||
There was a problem hiding this comment.
Do we know why we had these replace directives before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.