Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightIcon => Hds::Icon Migration - packages/components #2339

Merged
merged 30 commits into from
Aug 23, 2024

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Aug 13, 2024

📌 Summary

If merged, this PR updates instances of FlightIcon within components to use the Hds::Icon component.

🔗 External links

Jira ticket: HDS-3709


💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 23, 2024 3:58pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 23, 2024 3:58pm

@aklkv
Copy link
Contributor

aklkv commented Aug 13, 2024

A few spots you might want to remove references to ember-flight-icons packages:

"prepublishOnly": "yarn workspace @hashicorp/ember-flight-icons build && yarn build && test -f 'dist/styles/@hashicorp/design-system-components.css' || (echo 'The pre-compiled CSS file was not found' && exit 1)",

"@hashicorp/ember-flight-icons": "^5.1.3",

'../../node_modules/@hashicorp/ember-flight-icons/dist/styles',

'./node_modules/@hashicorp/ember-flight-icons/dist/styles',

once all other PRs are merged CI references needs to be cleaned up as well

@zamoore zamoore force-pushed the 3709-internal-icon-migration__components branch from d2e0447 to 194b750 Compare August 23, 2024 15:53
@zamoore zamoore merged commit 57c7230 into main Aug 23, 2024
16 checks passed
@zamoore zamoore deleted the 3709-internal-icon-migration__components branch August 23, 2024 16:25
@hashibot-hds hashibot-hds mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants