Fix Stepper::indicator::Task colors
#2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jorytindall
commented
Sep 5, 2024
| $hds-stepper-indicator-task-size: 16px; | ||
|
|
||
| // Determine states and corresponding styles | ||
| $hds-stepper-indicator-task-status-props: ( | ||
| "incomplete": ( | ||
| "color-default": var(--token-color-palette-neutral-300), | ||
| "color-hover": var(--token-color-palette-blue-300), | ||
| "color-active": var(--token-color-palette-blue-400), | ||
| "color-hover": var(--token-color-foreground-action-hover), |
There was a problem hiding this comment.
It's not possible to map all of these colors to semantic variables, but in this scenario it seems logical to do it where we can.
shleewhite
approved these changes
Sep 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR updates the
Stepper::Indicator::Taskto use colors from the semantic palette instead of the core palette. This results in no visual change and was uncovered as a small improvement that could be made during the Figma v2.0 project.I've marked this as a draft for now as there is still some discussion around some other updates that could be made to the Stepper Indicator to match the button (and vice versa).On second thought, I think it makes sense to determine these updates incrementally, the color questions with regards to the
Stepper::Indicator::Steprequire more discussion and potentially a more holistic solution.🔗 External links
Jira ticket: HDS-3815
Figma file: Stepper Indicator
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.