-
Notifications
You must be signed in to change notification settings - Fork 123
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go version missing from documentations. #37
Comments
Counterpoint: the go team themselves doesn't even support farther back than 2 versions, 1.14 was released in February which means even at the time of writing this issue 1.12 was not officially supported by the go team; is there a reason this package should support more than what is officially supported (assuming no, there is no reason to assume anything before 1.13 would work, with the release of 1.15 in August that would actually be 1.14 as the earliest officially supported version of Go)? |
Having random errors like
How does one tell I need to upgrade go? I have no idea how package mangagement works in Go, but I'm used to version constraint explanations in other langs/package managers (js/php) etc. |
Hmm, yeah this should be documented. FWIW, v1.0.0 supports go < 1.13, while v1.1.0 requires go 1.13. I also notice that in the go.mod file, the line
(emphasis mine). Of course, because there's this ticket, this doesn't seem sufficient, but the requirement does exist. I would be happy to review any PRs that came in for documenting the required go version Edit: ahh, I think the behavior I see above (where it says the module requires go 1.14) was added in a later version of go than you might be using @webmaster777, so you didn't see the message. I think we should still document it, but my advice would be to use a version of go at most one "major" version out of date. To quote from the go release page:
|
Fixed after upgrading to Go 1.15. I was importing |
I'm using golang v1.12 but this package is not supported because of errors.Is and errors.As functions which are not present in v1.12 and was added in v1.13. And there is no version requirement mentioned in the documentation. for this package
The text was updated successfully, but these errors were encountered: