Skip to content

Commit

Permalink
grpc stream errors are terminal
Browse files Browse the repository at this point in the history
Return after all grpc stream errors in in the stdio client, as any
stream error is final.

Reduce EOF exit log to DEBUG. This case is unavoidable, and causes
unnecessary log noise.
  • Loading branch information
jbardin committed Oct 19, 2020
1 parent 4c2f063 commit fa53be6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions grpc_stdio.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,12 @@ func (c *grpcStdioClient) Run(stdout, stderr io.Writer) {
status.Code(err) == codes.Canceled ||
status.Code(err) == codes.Unimplemented ||
err == context.Canceled {
c.log.Warn("received EOF, stopping recv loop", "err", err)
c.log.Debug("received EOF, stopping recv loop", "err", err)
return
}

c.log.Error("error receiving data", "err", err)
continue
return
}

// Determine our output writer based on channel
Expand Down

0 comments on commit fa53be6

Please sign in to comment.