HTTP client factory for per-request clients #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
force-pushed
the
ash2k/client-factory
branch
from
2d48af8
to
d4fb2fe
Compare
|
@ryanuber PTAL |
Merged
ash2k
commented
Oct 19, 2021
| type CleanPooledClientFactory struct { | ||
| } | ||
|
|
||
| func (f *CleanPooledClientFactory) New() HTTPClient { |
There was a problem hiding this comment.
Something to consider is adding an error to the returned values. Some factories may have a problem while constructing a client and they will not have a good way to propagate the error up. WDYT?
|
|
ash2k
force-pushed
the
ash2k/client-factory
branch
from
d4fb2fe
to
56e7391
Compare
|
Rebased. This is ready for review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #139 (comment) for the background.
This approach allows the library user to decide how they want to handle any client/transport related concerns. It decouples the library from those concerns as it doesn't have to have an opinion on how keep-alives need to work. Different situations need different behavior so giving users full control is the best option.