Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expiring cache use callback #79

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

yigongliu-concur
Copy link
Contributor

  • support simple expiring caches backed by eviction logic of existing 2q, arc and simple lru:

    NewExpiring2Q(size int, expirationTime time.Duration)
    NewExpiringARC(size int, expirationTime time.Duration)
    NewExpiringLRU(size int, expirationTime time.Duration)

  • no changes to existing api, no client code change if not using expiring cache.

  • client code can register callback to receive evicted/expired keys/vals.

  • there are 2 expiring policies similar to Guava's CacheBuilder (https://guava.dev/releases/19.0/api/docs/com/google/common/cache/CacheBuilder.html): ExpireAfterWrite and ExpireAfterAccess

  • the default cleanup of expired entries is lazy, only when space is needed for new entries (inside Add) or accurate keys (inside Keys) and size (inside Len) are needed; can add background cleanup by a goroutine periodically calling RemoveAllExpired()

  • following same pattern of simple LRU, separate 2q/arc Cache from LRU, so that XXXCache is just a thread safe wrapper of XXXLRU. this avoids the double locking when ExpiringCache wraps 2Q or ARC.

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants