Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should resolver.Run return when buffering.. error or content? #62

Open
eikenb opened this issue Jul 20, 2021 · 0 comments
Open

What should resolver.Run return when buffering.. error or content? #62

eikenb opened this issue Jul 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@eikenb
Copy link
Contributor

eikenb commented Jul 20, 2021

The ResolveEvent that is returned during buffering doesn't have the content which would otherwise always be available with the caching template (PR #59) and the error is nil. This breaks with the other return semantics where it either returns a meaningful ResolveEvent with content OR returns a empty/default ResolveEvent and an error.

This can be addressed in either direction.

  1. add a method to the template to let the resolver grab the cached content and return a meaningful ResolveEvent (w/ content and NoChange=true).
  2. have it return an error when buffering with the empty/default ResolveEvent (like other errors)

I'm leaning towards option 2 but am not 100% yet.

@eikenb eikenb added the bug Something isn't working label Jul 20, 2021
@eikenb eikenb changed the title What shold resolver.Run returnt when buffering.. error or content? What should resolver.Run returnt when buffering.. error or content? Sep 25, 2021
@eikenb eikenb changed the title What should resolver.Run returnt when buffering.. error or content? What should resolver.Run return when buffering.. error or content? Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant