Cached template #59
Merged
Cached template #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated this to have the standard Template cache the contents. I think the API is simpler and more consistent if it always returns the contents. |
eikenb
force-pushed
the
cached-template
branch
2 times, most recently
from
69c7ea1
to
b817782
Compare
lornasong
approved these changes
Jul 20, 2021
CachedTemplate is a new Template that caches the content and returns it when template.Execute is called with no changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Template to cache the contents and returns it when template.Execute is called with no changes.
Based on resolver-run-return-data branch and depends on it being merged first.