-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove obsolete path check #353
Conversation
Apparently this check is obsolete (see hashicorp/packer#6975) and still has an open issue (hashicorp#3). With this check in place, any attempt to use the vsphere-template post-processor seems to fail with errors like: Error: Failed preparing post-processor-block "vsphere-template" "" on ubuntu-2204.pkr.hcl line 303: (source code not available) 1 error(s) occurred: * Folder must be bound to the root
Error: post-processor/vsphere-template/post-processor.go:13:2: "strings" imported and not used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see this is assigned to me, but I do not see any action that I can take. It seems like we are waiting on one more code reviewer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cyberops7,
Thanks for the PR and the ping.
The code looks good to me, we can probably merge this soon.
@tenthirtyam did you have anything else in mind that should change here? If this looks good to you as well we can merge this one today I'd think
No other changes from my side, Lucas. |
It's a merge then, thanks for the confirmation @tenthirtyam ! |
Apparently this check is obsolete (see hashicorp/packer#6975, specifically "You're right, the folder bound to the root doesn't do any effect at code level, that was because the first implementation used to use that, sadly I forgot to remove it when I changed it.") and still has an open issue (#3). With this check in place, any attempt to use the vsphere-template post-processor seems to fail with errors like:
This was tested against the latest version.
gist with DEBUG log output: https://gist.github.com/cyberops7/751cd2f23189579f487174c7580f594a
Test case: include the
vsphere-template
post-processor block:Closes #3