Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/vmware/govmomi from 0.36.2 to 0.37.1 #422

Merged
merged 1 commit into from
May 9, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Summary

  • Updates vmware/govmom from 0.36.2 to 0.37.1.
  • Due to a change in 0.37.0 of vmware/govmom, the ReconfigureFail needed to be removed. The CreateTask method in the TaskManager struct was updated. The new method now checks if the provided TaskTypeId is valid before proceeding. If it's not valid, it returns a SOAP fault with an InvalidArgument error.

Testing

packer-plugin-vsphere git:(chore(deps)-govmomi) ✗ go get -u github.com/vmware/govmomi                                          
go: upgraded github.com/vmware/govmomi v0.36.2 => v0.37.1packer-plugin-vsphere git:(chore(deps)-govmomi) ✗ go mod tidypacker-plugin-vsphere git:(chore(deps)-govmomi) ✗ make generate
2024/05/01 13:44:33 Copying "docs" to ".docs/"
2024/05/01 13:44:33 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...packer-plugin-vsphere git:(chore(deps)-govmomi) ✗ make buildpacker-plugin-vsphere git:(chore(deps)-govmomi) ✗ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.152s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       3.629s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       8.437s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.859s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   9.113s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       4.293s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      5.244s

Reference

Ref: vmware/govmomi@9c59e9c#diff-b69f2c4e19456b811639643ed5dfe09357a280ac81b47249a14d6e625ef46317

- Updates `vmware/govmom` from 0.36.2 to 0.37.1.
- Due to a change in 0.37.0 of `vmware/govmom`, the `ReconfigureFail` needed to be removed. The CreateTask method in the TaskManager struct was updated. The new method now checks if the provided TaskTypeId is valid before proceeding. If it's not valid, it returns a SOAP fault with an InvalidArgument error.

Ref: vmware/govmomi@9c59e9c#diff-b69f2c4e19456b811639643ed5dfe09357a280ac81b47249a14d6e625ef46317

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v1.3.0 milestone May 1, 2024
@tenthirtyam tenthirtyam self-assigned this May 1, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 1, 2024 17:57
@lbajolet-hashicorp lbajolet-hashicorp merged commit f0b7325 into main May 9, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(deps)-govmomi branch May 9, 2024 13:24
@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants