Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add encrypted option for root block device and add ebs specifications #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szaki99
Copy link

@szaki99 szaki99 commented Dec 9, 2019

The goal is to have encrypted root block device and ebs encrypted block device.

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


sylvain zaki seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

volume_type = var.ebs_volume_type
delete_on_termination = var.ebs_volume_delete_on_termination
encrypted = var.ebs_volume_encrypted
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not always add an EBS block device. Instead, add a new ebs_block_devices input variable, which contains a list of objects, and use that as the value with for_each. The default will be an empty list to maintain backwards compatibility, but now you can override the list to add one or more EBS volumes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants