Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Miscellaneous doc fixes in attribute + unit tests #1027

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Aug 14, 2024

Just some cleaning up I found while working on something else.


FYI, for the unit tests being uncommented, they were originally failing because collection types with missing element types are considered invalid, and thus not equal:

// Preserve prior ElemType nil check behavior
if l.ElementType().Equal(missingType{}) {
return false
}

Since all these custom type tests were embedding the underlying collection type, the element type was nil, thus failing the cmp.Diff in all the tests with a confusing diff 😆

--- FAIL: TestMapNestedAttributeGetType (0.00s)
    --- FAIL: TestMapNestedAttributeGetType/custom-type (0.00s)
        /Users/austin.valle/code/terraform-plugin-framework/resource/schema/map_nested_attribute_test.go:411: unexpected difference:   testtypes.MapType(
            - 	{},
            + 	{},
              )

The int64/int32/float64/float32/object unit tests were never failing, but likely just commented out on accident 👍🏻

@austinvalle austinvalle added the documentation Improvements or additions to documentation label Aug 14, 2024
@austinvalle austinvalle requested a review from a team as a code owner August 14, 2024 13:39
@austinvalle
Copy link
Member Author

austinvalle commented Aug 14, 2024

Also contains the linter fixes for go 1.23 😆

Edit: Framework linting fixes are in main now!

@austinvalle austinvalle enabled auto-merge (squash) August 14, 2024 13:46
hashicorp-tsccr bot and others added 10 commits September 17, 2024 10:27
* Result of tsccr-helper -log-level=info gha update -latest .

* Resolve linter errors and warnings

---------

Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: Selena Goods <github@simplebox.anonaddy.com>
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/hashicorp/setup-terraform/releases)
- [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
- [Commits](hashicorp/setup-terraform@651471c...b9cd54a)

---
updated-dependencies:
- dependency-name: hashicorp/setup-terraform
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
* all: Bump minimum Go module version to 1.22.7

* add changelog

* back to 1.22.0
@austinvalle austinvalle enabled auto-merge (squash) September 17, 2024 14:29
@austinvalle austinvalle merged commit 7076cca into main Sep 17, 2024
29 checks passed
@austinvalle austinvalle deleted the av/doc-fixes branch September 17, 2024 15:23
austinvalle added a commit that referenced this pull request Sep 17, 2024
* fix and uncomment custom type tests

* fix comments on nested attributes

* add new attribute types to package docs

* fix map docs

* fix linting errors

* SEC-090: Automated trusted workflow pinning (2024-08-19) (#1028)

* Result of tsccr-helper -log-level=info gha update -latest .

* Resolve linter errors and warnings

---------

Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: Selena Goods <github@simplebox.anonaddy.com>

* build(deps): Bump hashicorp/setup-terraform from 3.1.1 to 3.1.2 (#1029)

Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/hashicorp/setup-terraform/releases)
- [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
- [Commits](hashicorp/setup-terraform@651471c...b9cd54a)

---
updated-dependencies:
- dependency-name: hashicorp/setup-terraform
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Result of tsccr-helper -log-level=info gha update -latest . (#1034)

Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>

* all: Bump minimum Go module version to 1.22 (#1033)

* all: Bump minimum Go module version to 1.22.7

* add changelog

* back to 1.22.0

* [CI] Update lock workflow file

* [CI] Update issue comment triage workflow file

* [CI] terraform-devex-repos automation

* [CI] terraform-devex-repos automation

* [CI] terraform-devex-repos automation

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: hashicorp-tsccr[bot] <129506189+hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
Co-authored-by: Selena Goods <github@simplebox.anonaddy.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Service Account - Terraform Provider DevEx <100357958+hc-github-team-tf-provider-devex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants