provider: Remove extraneous AWS Go SDK value wrapping in d.Set()

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The (*schema.ResourceData).Set() receiver method automatically handles pointer types and nil values, so wrapping the values with the AWS Go SDK pointer conversion functions, e.g. aws.StringValue() is extraneous.

Note: This should not include slice/map functions calls such as aws.StringValueSlice() since those conversions are not automatic.

Example semgrep Rule

rules:
  - id: helper-schema-ResourceData-Set-extraneous-value-pointer-conversion
    languages: [go]
    message: AWS Go SDK pointer conversion function for `d.Set()` value is extraneous
    paths:
      include:
        - aws/
    patterns:
      - pattern-either:
        - pattern: d.Set($ATTRIBUTE, aws.BoolValue($APIOBJECT))
        - pattern: d.Set($ATTRIBUTE, aws.Int64Value($APIOBJECT))
        - pattern: d.Set($ATTRIBUTE, int(aws.Int64Value($APIOBJECT)))
        - pattern: d.Set($ATTRIBUTE, aws.StringValue($APIOBJECT))
    severity: WARNING

Example Reports

aws/resource_aws_wafv2_rule_group.go
severity:warning rule:helper-schema-ResourceData-Set-extraneous-value-wrapping: AWS Go SDK value wrapping in `d.Set()` is extraneous
188:	d.Set("name", aws.StringValue(resp.RuleGroup.Name))
189:	d.Set("capacity", aws.Int64Value(resp.RuleGroup.Capacity))
190:	d.Set("description", aws.StringValue(resp.RuleGroup.Description))
191:	d.Set("arn", aws.StringValue(resp.RuleGroup.ARN))
192:	d.Set("lock_token", aws.StringValue(resp.LockToken))

aws/resource_aws_wafv2_web_acl.go
severity:warning rule:helper-schema-ResourceData-Set-extraneous-value-wrapping: AWS Go SDK value wrapping in `d.Set()` is extraneous
215:	d.Set("name", aws.StringValue(resp.WebACL.Name))
216:	d.Set("capacity", aws.Int64Value(resp.WebACL.Capacity))
217:	d.Set("description", aws.StringValue(resp.WebACL.Description))
218:	d.Set("arn", aws.StringValue(resp.WebACL.ARN))
219:	d.Set("lock_token", aws.StringValue(resp.LockToken))

aws/resource_aws_worklink_fleet.go
severity:warning rule:helper-schema-ResourceData-Set-extraneous-value-wrapping: AWS Go SDK value wrapping in `d.Set()` is extraneous
176:	d.Set("name", aws.StringValue(resp.FleetName))
177:	d.Set("display_name", aws.StringValue(resp.DisplayName))
178:	d.Set("optimize_for_end_user_location", aws.BoolValue(resp.OptimizeForEndUserLocation))
179:	d.Set("company_code", aws.StringValue(resp.CompanyCode))

Affected Resources

TBD

Definition of Done

• Rule added to .semgrep.yml with no reports on main branch and CI passes

[ghost]

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!