tech-debt/resources:autofix extraneous value conversion for d.Set() of primitives

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16554

Release note for CHANGELOG:

N/A

Output from acceptance testing:

N/A semgrep rule (defined in https://github.com/hashicorp/terraform-provider-aws/pull/16650) should not show warning msgs for these files

[YakDriver]

LGTM (once the conflict is resolved)

[anGie44]

@bflad confirmed removing the AWS SDK value conversions does not change the output value of an API object String field e.g.

With terraform config:

resource "aws_msk_configuration" "test" {
  kafka_versions = ["2.1.0"]
  name           = "tf-test-1234"

  server_properties = <<PROPERTIES
auto.create.topics.enable = true
delete.topic.enable = true
PROPERTIES
}

output "test" {
  value = aws_msk_configuration.test.description
}

Terraform apply output (using tf v0.14 and aws provider v3.34.0):

aws_msk_configuration.test: Creating...
aws_msk_configuration.test: Still creating... [10s elapsed]
aws_msk_configuration.test: Creation complete after 12s [id=arn:aws:kafka:us-west-2:xxxxxxxxx:configuration/tf-test-1234/5edd0390-9c3b-4ad6-90d0-d1e04d91e2e5-6]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Value in terraform state file:

"description": "",

Running terraform refresh:

Outputs:

test = ""

Then upgrading to a provider built from this branch and running terraform apply:

aws_msk_configuration.test: Refreshing state... [id=arn:aws:kafka:us-west-2:xxxxxxxxxxx:configuration/tf-test-1234/5edd0390-9c3b-4ad6-90d0-d1e04d91e2e5-6]

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

test = ""

Similarly if we run the above configuration, creating a new resource, just on the provider built from this branch:

aws_msk_configuration.test: Creating...
aws_msk_configuration.test: Creation complete after 1s [id=arn:aws:kafka:us-west-2:xxxxxxxx:configuration/tf-test-1234/3d0a1187-13ee-4390-b205-eb671f9b05a2-6]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Running terraform refresh:

aws_msk_configuration.test: Refreshing state... [id=arn:aws:kafka:us-west-2:xxxxxxxxxxx:configuration/tf-test-1234/3d0a1187-13ee-4390-b205-eb671f9b05a2-6]

Outputs:

test = ""

[bflad]

This is wonderful! Thank you for the extra careful validation. 🚀

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!