Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_replication_group, data_source/aws_elasticache_replication_group: Migrate to parameters matching API parameters #18440

Closed
gdavison opened this issue Mar 27, 2021 · 3 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@gdavison
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The resource and data source aws_elasticache_replication_group have a number of parameters that do not match the API parameters. New parameters matching the API parameters should be added to the resource and data source.

Resource:

  • add num_cache_clusters, deprecate number_cache_clusters
  • add num_node_groups and replicas_per_node_group, deprecate cluster_mode
  • add description, deprecate replication_group_description

Data Source:

  • add num_cache_clusters, deprecate number_cache_clusters
  • add num_node_groups and replicas_per_node_group
  • add description, deprecate replication_group_description
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 27, 2021
@gdavison gdavison added service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Mar 27, 2021
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 11, 2022
@anGie44 anGie44 self-assigned this Jan 19, 2022
@anGie44
Copy link
Contributor

anGie44 commented Feb 2, 2022

Addressed in #22666 and #22667

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

2 participants