Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_replication_group, data_source/aws_elasticache_replication_group: Remove deprecated parameters #18441

Closed
gdavison opened this issue Mar 27, 2021 · 6 comments · Fixed by #31008
Closed

resource/aws_elasticache_replication_group, data_source/aws_elasticache_replication_group: Remove deprecated parameters #18441

gdavison opened this issue Mar 27, 2021 · 6 comments · Fixed by #31008
Assignees
@YakDriver
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v5.0.0

Comments

@gdavison
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

#18440 deprecates the following parameters on resource and data source aws_elasticache_replication_group. Remove them.

Resource:

  • number_cache_clusters
  • cluster_mode
  • replication_group_description

Data Source:

  • number_cache_clusters
  • replication_group_description
@gdavison gdavison added enhancement Requests to existing resources that expand the functionality or scope. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Mar 27, 2021
@gdavison gdavison added this to the v4.0.0 milestone Mar 27, 2021
@rahul-amzn
Copy link
Contributor

I will look into this.

@anGie44 anGie44 modified the milestones: v4.0.0, v5.0.0 Jan 19, 2022
@rquadling
Copy link
Contributor

I'm having issues with terraform validate -json with these deprecations (#22903). Would appreciate a "it's us, not you" answer as I'm not sure what's happening.

@YakDriver YakDriver self-assigned this Apr 27, 2023
@YakDriver YakDriver mentioned this issue Apr 27, 2023
Merged
@YakDriver YakDriver linked a pull request May 2, 2023 that will close this issue
elasticache/rep_group: Remove availability zones and other deprecated parameters #31008
Merged
@ewbankkit
Copy link
Contributor

Relates #22666.

@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #31008, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v5.0.0
7 participants
@rquadling @gdavison @ewbankkit @anGie44 @jar-b @YakDriver @rahul-amzn