Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apache Flink v1.13 #21341

Conversation

irisgve
Copy link
Contributor

@irisgve irisgve commented Oct 18, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21339.

Release note for CHANGELOG

resource/aws_kinesisanalyticsv2_application: `runtime_environment` now supports `FLINK-1_13`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Oct 18, 2021
@irisgve irisgve force-pushed the f-aws_kinesisanalyticsv2_application-FLINK-1_13 branch from a46d7f9 to af6f09e Compare October 18, 2021 06:28
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@irisgve irisgve marked this pull request as ready for review October 20, 2021 23:29
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKinesisAnalyticsV2Application_basicFlinkApplication' PKG_NAME=internal/service/kinesisanalyticsv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesisanalyticsv2 -v -count 1 -parallel 20 -run=TestAccKinesisAnalyticsV2Application_basicFlinkApplication -timeout 180m
=== RUN   TestAccKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccKinesisAnalyticsV2Application_basicFlinkApplication
=== CONT  TestAccKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccKinesisAnalyticsV2Application_basicFlinkApplication (75.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	80.834s

@ewbankkit
Copy link
Contributor

@irisgve Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5ae69c9 into hashicorp:main Oct 21, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 21, 2021
@irisgve irisgve deleted the f-aws_kinesisanalyticsv2_application-FLINK-1_13 branch October 21, 2021 22:04
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Kinesis Data Analytics now supports Apache Flink v1.13
3 participants