Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting: Restore code generation checks #21356

Merged
merged 4 commits into from
Oct 19, 2021
Merged

linting: Restore code generation checks #21356

merged 4 commits into from
Oct 19, 2021

Conversation

gdavison
Copy link
Contributor

Restores linting for generated code, updates documentation, and removes unneeded exports

Relates #20000

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appstream Issues and PRs that pertain to the appstream service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/cloudwatchevents service/directconnect Issues and PRs that pertain to the directconnect service. service/ecs Issues and PRs that pertain to the ecs service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/workspaces Issues and PRs that pertain to the workspaces service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 18, 2021
GNUmakefile Outdated
@@ -14,6 +14,7 @@ build: fmtcheck
gen:
rm -f internal/service/**/*_gen.go
go generate ./...
goimports -w ./$(PKG_NAME)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add cd tools && go install golang.org/x/tools/cmd/goimports to the tools target, else

% make gen
rm -f internal/service/**/*_gen.go
go generate ./...
goimports -w ./internal
make: goimports: No such file or directory
make: *** [gen] Error 1
% cd tools && go install golang.org/x/tools/cmd/goimports
% goimports -w ./internal

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 19, 2021
@gdavison gdavison merged commit 69fce61 into main Oct 19, 2021
@gdavison gdavison deleted the svcpkg-codegen branch October 19, 2021 23:37
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 19, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/amplify Issues and PRs that pertain to the amplify service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appstream Issues and PRs that pertain to the appstream service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ecs Issues and PRs that pertain to the ecs service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants