Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(s3_object): add support of KMS alias #32124

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jeremychauvet
Copy link
Contributor

@jeremychauvet jeremychauvet commented Jun 21, 2023

Description

This PR adds support of KMS Key alias when uploading an object to an S3 bucket.

Relations

Closes #24921

References

https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Object_kms'  -timeout 180m
=== RUN   TestAccS3Object_kms
=== PAUSE TestAccS3Object_kms
=== RUN   TestAccS3Object_kmsAlias
=== PAUSE TestAccS3Object_kmsAlias
=== CONT  TestAccS3Object_kms
=== CONT  TestAccS3Object_kmsAlias
--- PASS: TestAccS3Object_kmsAlias (33.17s)
--- PASS: TestAccS3Object_kms (34.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 36.999s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 21, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 21, 2023
@jeremychauvet jeremychauvet marked this pull request as ready for review July 23, 2023 16:04
@jeremychauvet
Copy link
Contributor Author

MR ready for review 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'kms_key_id' of 'aws_s3_object' does not support alias notation
2 participants