Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_finspace: add sweepers #32643

Merged
merged 1 commit into from
Jul 26, 2023
Merged

r/aws_finspace: add sweepers #32643

merged 1 commit into from
Jul 26, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 21, 2023

Description

Adds a sweeper for the aws_finspace_kx_environment resource. All other aws_finspace_kx_* resources (cluster, database, user) live within an environment, so sweeping this resource will also delete those downstream components.

Relations

Relates #31802

Output from Acceptance Testing

$ make sweep SWEEPARGS="-sweep-run=aws_finspace"
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2,us-west-1 -sweep-run=aws_finspace -timeout 60m
2023/07/21 11:31:46 [DEBUG] Running Sweepers for region (us-west-2):
2023/07/21 11:31:46 [DEBUG] Running Sweeper (aws_finspace_kx_environment) in region (us-west-2)
...
2023/07/21 11:32:10 [DEBUG] Completed Sweeper (aws_finspace_kx_environment) in region (us-west-1) in 475.936292ms
2023/07/21 11:32:10 Completed Sweepers for region (us-west-1) in 476.043375ms
2023/07/21 11:32:10 Sweeper Tests for region (us-west-1) ran successfully:
        - aws_finspace_kx_environment
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      26.590s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. service/finspace Issues and PRs that pertain to the finspace service. labels Jul 21, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jul 21, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 608595b into main Jul 26, 2023
36 checks passed
@jar-b jar-b deleted the td-finspace-sweepers branch July 26, 2023 14:41
@github-actions github-actions bot added this to the v5.10.0 milestone Jul 26, 2023
github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
@github-actions
Copy link

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/finspace Issues and PRs that pertain to the finspace service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants