Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detective: Migrate to AWS SDK v2 #37195

Merged
merged 2 commits into from
Jul 16, 2024
Merged

detective: Migrate to AWS SDK v2 #37195

merged 2 commits into from
Jul 16, 2024

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Apr 30, 2024 •
edited by jar-b
Loading

Description

Relations

Closes #36137
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/detective Issues and PRs that pertain to the detective service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Apr 30, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Apr 30, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@mattburgess mattburgess added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Apr 30, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 1, 2024
@jar-b jar-b self-assigned this Jul 16, 2024
@jar-b jar-b requested a review from a team as a code owner July 16, 2024 14:02
jar-b
jar-b approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=detective
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/detective/... -v -count 1 -parallel 20   -timeout 360m

--- PASS: TestEndpointConfiguration (0.70s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_config_file_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_service_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_config_file (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config (0.05s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_base_envvar (0.04s)
    --- PASS: TestEndpointConfiguration/use_fips_config (0.03s)
    --- PASS: TestEndpointConfiguration/use_fips_config_with_package_name_endpoint_config (0.04s)
    --- PASS: TestEndpointConfiguration/service_aws_envvar_overrides_base_envvar (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/base_endpoint_envvar_overrides_base_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/service_config_file (0.03s)
    --- PASS: TestEndpointConfiguration/no_config (0.03s)
    --- PASS: TestEndpointConfiguration/package_name_endpoint_config_overrides_aws_service_envvar (0.04s)
=== CONT  TestAccDetective_serial
=== RUN   TestAccDetective_serial/Graph
=== RUN   TestAccDetective_serial/Graph/basic
=== RUN   TestAccDetective_serial/Graph/disappears
=== RUN   TestAccDetective_serial/Graph/tags
=== RUN   TestAccDetective_serial/InvitationAccepter
=== RUN   TestAccDetective_serial/InvitationAccepter/basic
    detective_test.go:46: Environment variable AWS_DETECTIVE_MEMBER_EMAIL is not set. To properly test inviting Detective member accounts, a valid email associated with the alternate AWS acceptance test account must be provided.
=== RUN   TestAccDetective_serial/Member
=== RUN   TestAccDetective_serial/Member/basic
    detective_test.go:46: Environment variable AWS_DETECTIVE_MEMBER_EMAIL is not set. To properly test inviting Detective member accounts, a valid email associated with the alternate AWS acceptance test account must be provided.
=== RUN   TestAccDetective_serial/Member/disappear
    detective_test.go:46: Environment variable AWS_DETECTIVE_MEMBER_EMAIL is not set. To properly test inviting Detective member accounts, a valid email associated with the alternate AWS acceptance test account must be provided.
=== RUN   TestAccDetective_serial/Member/message
    detective_test.go:46: Environment variable AWS_DETECTIVE_MEMBER_EMAIL is not set. To properly test inviting Detective member accounts, a valid email associated with the alternate AWS acceptance test account must be provided.
=== RUN   TestAccDetective_serial/OrganizationAdminAccount
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/MultiRegion
    organization_admin_account_test.go:83: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/basic
    organization_admin_account_test.go:27: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccDetective_serial/OrganizationAdminAccount/disappears
    organization_admin_account_test.go:56: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccDetective_serial/OrganizationConfiguration
=== RUN   TestAccDetective_serial/OrganizationConfiguration/basic
    organization_configuration_test.go:23: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccDetective_serial (54.41s)
    --- PASS: TestAccDetective_serial/Graph (51.55s)
        --- PASS: TestAccDetective_serial/Graph/basic (14.10s)
        --- PASS: TestAccDetective_serial/Graph/disappears (10.35s)
        --- PASS: TestAccDetective_serial/Graph/tags (27.10s)
    --- PASS: TestAccDetective_serial/InvitationAccepter (0.00s)
        --- SKIP: TestAccDetective_serial/InvitationAccepter/basic (0.00s)
    --- PASS: TestAccDetective_serial/Member (0.00s)
        --- SKIP: TestAccDetective_serial/Member/basic (0.00s)
        --- SKIP: TestAccDetective_serial/Member/disappear (0.00s)
        --- SKIP: TestAccDetective_serial/Member/message (0.00s)
    --- PASS: TestAccDetective_serial/OrganizationAdminAccount (2.54s)
        --- SKIP: TestAccDetective_serial/OrganizationAdminAccount/MultiRegion (0.30s)
        --- SKIP: TestAccDetective_serial/OrganizationAdminAccount/basic (0.22s)
        --- SKIP: TestAccDetective_serial/OrganizationAdminAccount/disappears (2.02s)
    --- PASS: TestAccDetective_serial/OrganizationConfiguration (0.32s)
        --- SKIP: TestAccDetective_serial/OrganizationConfiguration/basic (0.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  61.262s

@jar-b
Copy link
Member

jar-b commented Jul 16, 2024

Thanks for your contribution, @mattburgess! 🚀

@jar-b jar-b merged commit 2177e08 into hashicorp:main Jul 16, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/detective Issues and PRs that pertain to the detective service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.59.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Detective Service
3 participants
@mattburgess @jar-b @justinretzolk