-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ecs_service: add tag_specification support #38662
Merged
johnsonaj
merged 10 commits into
hashicorp:main
from
trutled3:f-aws_ecs_service_tag_specifications
Sep 20, 2024
Merged
aws_ecs_service: add tag_specification support #38662
johnsonaj
merged 10 commits into
hashicorp:main
from
trutled3:f-aws_ecs_service_tag_specifications
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/ecs
Issues and PRs that pertain to the ecs service.
needs-triage
Waiting for first response or review from a maintainer.
labels
Aug 2, 2024
trutled3
changed the title
F aws ecs service tag specifications
aws_ecs_service: add tag_specification support
Aug 2, 2024
justinretzolk
added
enhancement
Requests to existing resources that expand the functionality or scope.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Aug 6, 2024
F_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_VolumeConfiguration_TagSpecifications' -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/datazone v1.16.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ecr v1.31.0
go: downloading github.com/aws/aws-sdk-go-v2/service/resiliencehub v1.23.3
go: downloading github.com/aws/aws-sdk-go-v2/service/workspaces v1.44.3
go: downloading github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.9
=== RUN TestAccECSService_VolumeConfiguration_TagSpecifications
=== PAUSE TestAccECSService_VolumeConfiguration_TagSpecifications
=== CONT TestAccECSService_VolumeConfiguration_TagSpecifications
--- PASS: TestAccECSService_VolumeConfiguration_TagSpecifications (68.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 74.724s |
johnsonaj
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSService_VolumeConfiguration_\|TestAccECSService_basic\|TestAccECSService_disappears -timeout 360m
--- PASS: TestAccECSService_basic (71.83s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (73.43s)
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (73.55s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (81.99s)
--- PASS: TestAccECSService_VolumeConfiguration_update (114.32s)
--- PASS: TestAccECSService_basicImport (187.66s)
--- PASS: TestAccECSService_disappears (191.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 198.078s
@trutled3 thank you for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
enhancement
Requests to existing resources that expand the functionality or scope.
service/ecs
Issues and PRs that pertain to the ecs service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the tag specifications capability from the CreateService API for AWS ECS. I am unable to perform the acceptance testing, if someone could please run it for me. I have provided the command below.
Relations
Closes #38486
References
Output from Acceptance Testing
% make testacc TESTS=TestAccECSService_VolumeConfiguration_TagSpecifications PKG=ecs