Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Opensearch resources to AWS SDK v2 #38901

Merged
merged 30 commits into from
Aug 19, 2024
Merged

Migrate Opensearch resources to AWS SDK v2 #38901

merged 30 commits into from
Aug 19, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 16, 2024 •
edited
Loading

Description

This PR migrates the remaining Opensearch resources to AWS SDKv2.

Testing this service is quite tricky as each test can take up more than an hour and some of them include creating VPCs.
By running 20 of them parallel you will run in VPCLimitExceptions by making this smaller, the entire test can take up to 18 hours.

Relations

Closes #36192
Closes #33897
Relates #32976

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAcc' PKG=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAcc -timeout 720m
--- PASS: TestAccOpenSearchDomain_VolumeType_missing (1515.27s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestDefaultKey (1679.21s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNode (1801.67s)
--- PASS: TestAccOpenSearchDomain_tags (2014.83s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs (2062.20s)
--- PASS: TestAccOpenSearchInboundConnectionAccepter_basic (2105.92s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestSpecifyKey (2178.96s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2198.69s)
--- PASS: TestAccOpenSearchDomain_Policy_ignoreEquivalent (2213.59s)
--- PASS: TestAccOpenSearchDomain_offPeakWindowOptions (2213.98s)
--- PASS: TestAccOpenSearchOutboundConnection_disappears (2216.11s)
--- PASS: TestAccOpenSearchDomain_Policy_addPrincipal (2282.15s)
--- PASS: TestAccOpenSearchDomain_VolumeType_gp3ToGP2 (2454.88s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_auditLogs (2473.37s)
--- PASS: TestAccOpenSearchDomain_Policy_basic (1868.15s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs (2112.30s)
--- PASS: TestAccOpenSearchPackage_disappears (22.39s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_iam (1842.76s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs (1949.18s)
--- PASS: TestAccOpenSearchDomain_CognitoOptions_createAndRemove (4073.29s)
--- PASS: TestAccOpenSearchDomain_VPC_internetToVPCEndpoint (4137.86s)
--- PASS: TestAccOpenSearchVPCEndpoint_disappears (2806.74s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnableLegacy (4110.74s)
--- PASS: TestAccOpenSearchVPCEndpoint_basic (2410.44s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled (2086.00s)
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (2013.91s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB (2389.36s)
--- PASS: TestAccOpenSearchOutboundConnection_basic (2466.72s)
--- PASS: TestAccOpenSearchOutboundConnection_vpc (2644.05s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnable (5241.39s)
--- PASS: TestAccOpenSearchDomain_duplicate (1175.55s)
--- PASS: TestAccOpenSearchDomain_CognitoOptions_update (3636.17s)
--- PASS: TestAccOpenSearchDomain_v23 (1679.34s)
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy (5788.50s)
--- PASS: TestAccOpenSearchDomain_ipAddressType (3646.34s)
=== CONT  TestAccOpenSearchPackage_basic
    package_test.go:25: Step 1/2 error: Check failed: Check 2/7 error: aws_opensearch_package.test: Attribute 'available_package_version' expected "v1", got ""
--- FAIL: TestAccOpenSearchPackage_basic (14.20s)
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnable (5936.68s)
--- PASS: TestAccOpenSearchDomain_complex (2089.32s)
--- PASS: TestAccOpenSearchDomain_VolumeType_update (6656.87s)
--- PASS: TestAccOpenSearchDomain_VPC_update (4375.89s)
--- PASS: TestAccOpenSearchVPCEndpoint_update (2981.55s)
--- PASS: TestAccOpenSearchDomain_requireHTTPS (1865.38s)
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth (5032.69s)
--- PASS: TestAccOpenSearchDomain_customEndpoint (2126.04s)
--- PASS: TestAccOpenSearchDomain_softwareUpdateOptions (2004.50s)
--- PASS: TestAccOpenSearchDomain_disappears (1938.12s)        
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (3275.13s)
--- PASS: TestAccOpenSearchDomain_basic (1889.74s)
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (5768.62s)
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3324.52s)
--- PASS: TestAccOpenSearchInboundConnectionAccepter_disappears (2153.81s)
--- PASS: TestAccOpenSearchDomain_Cluster_warm (6058.35s)
--- PASS: TestAccOpenSearchDomainSAMLOptions_disappears_Domain (2119.63s)
--- PASS: TestAccOpenSearchDomainSAMLOptions_Update (2271.26s)
--- PASS: TestAccOpenSearchDomainSAMLOptions_Disabled (2491.05s)
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (8064.34s)
--- PASS: TestAccOpenSearchDomain_VPC_basic (5985.69s)
--- PASS: TestAccOpenSearchDomainSAMLOptions_basic (2251.71s)
--- PASS: TestAccOpenSearchPackageAssociation_disappears (2166.31s)
--- PASS: TestAccOpenSearchPackageAssociation_basic (2233.50s)
--- PASS: TestAccOpenSearchDomainPolicy_basic (2469.24s)
--- PASS: TestAccOpenSearchDomain_Cluster_update (3925.93s)
--- PASS: TestAccOpenSearchDomain_versionUpdate (5126.84s)
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2460.95s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	13540.257s
FAIL

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/opensearch Issues and PRs that pertain to the opensearch service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 16, 2024
@DanielRieske DanielRieske mentioned this pull request Aug 16, 2024
Closed
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 16, 2024
@DanielRieske DanielRieske marked this pull request as ready for review August 18, 2024 20:20
@DanielRieske DanielRieske requested a review from a team as a code owner August 18, 2024 20:20
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2024
@ewbankkit ewbankkit self-assigned this Aug 18, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 18, 2024
@DanielRieske
Copy link
Contributor Author

DanielRieske commented Aug 19, 2024 •
edited
Loading

I ran the sweepers as well, usually I skip that step but it seems I was a bit careless in #38920

% SWEEP=us-west-2 SWEEPERS=aws_opensearch_domain,aws_opensearch_inbound_connection_accepter,aws_opensearch_outbound_connection make sweep 
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go1.22.6 test ./internal/sweep -v -sweep=us-west-2 -sweep-run='aws_opensearch_domain,aws_opensearch_inbound_connection_accepter,aws_opensearch_outbound_connection' -timeout 360m
2024/08/19 19:03:16 [DEBUG] Running Sweepers for region (us-west-2):
2024/08/19 19:03:16 [DEBUG] Running Sweeper (aws_opensearch_inbound_connection_accepter) in region (us-west-2)
2024/08/19 19:03:16 [DEBUG] sweeper: Configuring Terraform AWS Provider: sweeper_region=us-west-2
2024-08-19T19:03:16.251+0200 [DEBUG] sweeper.aws-base: Resolving credentials provider: sweeper_region=us-west-2
2024-08-19T19:03:16.251+0200 [DEBUG] sweeper.aws-base: Using profile: tf_aws.profile=default tf_aws.profile.source=envvar sweeper_region=us-west-2
2024-08-19T19:03:16.251+0200 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2024-08-19T19:03:16.255+0200 [DEBUG] sweeper.aws-base: Retrieving credentials: sweeper_region=us-west-2
2024-08-19T19:03:16.255+0200 [INFO]  sweeper.aws-base: Retrieved credentials: sweeper_region=us-west-2
2024-08-19T19:03:16.255+0200 [DEBUG] sweeper.aws-base: Loading configuration: sweeper_region=us-west-2
2024/08/19 19:03:16 [DEBUG] sweeper: Creating AWS SDK v1 session: sweeper_region=us-west-2
2024/08/19 19:03:16 [DEBUG] sweeper: Retrieving AWS account details: sweeper_region=us-west-2
2024-08-19T19:03:16.257+0200 [DEBUG] sweeper.aws-base: Retrieving caller identity from STS: sweeper_region=us-west-2
2024-08-19T19:03:16.907+0200 [INFO]  sweeper.aws-base: Retrieved caller identity from STS: sweeper_region=us-west-2
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-058fa245-1996-48fc-ac74-3354ef0abed4: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-0ba70170-9ae7-4bec-9d97-560afe3b447a: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-1b4fe176-5a18-4d7e-bdac-72fdddbf933c: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-32448e60-02c5-4d7e-b731-9196fbd1dfbc: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-343d8cd3-dc40-473d-8264-c50ff0943474: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-3d8859f4-1e8a-4ab5-b2cf-efdc44e78c0f: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-443aa43c-9afd-4e78-bf6b-b4391457379f: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-4fbdfa16-259f-4185-b8e7-3d00f3e06bd4: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-5793a8e2-92b7-4d04-835a-cf6a16b76172: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-6183143a-66b8-494a-b081-80b319c43d14: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-6646f778-49d5-4971-9599-ebb5132c05bd: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-6a95c82d-fa03-415a-942c-0ae14d364d22: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-6e2041db-8b6f-469d-9330-f9245e8389cb: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-7e6a6b76-0df4-4a0c-b81a-85087684dd6b: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-7fb7d3f0-6f2c-4218-9059-86a09043027e: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-82eeb866-ca49-48b9-8faf-82c44c2f8931: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-87980723-119b-4784-baee-22c3f22f1ed2: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-909b9de6-bab0-456c-a38b-9d1954b3f592: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-936f0bbf-83bf-4e83-8ea8-b200f38a8568: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-b05e9f1c-6980-4d54-9915-4385437c8b8d: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-b6fe06a0-7ec0-46a6-a1b4-091fe17188e8: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-bcf5068a-53c3-430b-8bd9-b9e84b989b04: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-c6195fb7-30ad-44c4-8253-64ee98b9903f: DELETED
2024/08/19 19:03:17 [INFO] Skipping OpenSearch Inbound Connection cc-eb9a6d11-4b2e-47ca-8ad0-2d202ca6ee95: DELETED
2024/08/19 19:03:17 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:03:17 [DEBUG] Completed Sweeper (aws_opensearch_inbound_connection_accepter) in region (us-west-2) in 1.430847291s
2024/08/19 19:03:17 [DEBUG] Sweeper (aws_opensearch_domain) has dependency (aws_opensearch_inbound_connection_accepter), running..
2024/08/19 19:03:17 [DEBUG] Sweeper (aws_opensearch_inbound_connection_accepter) already ran in region (us-west-2)
2024/08/19 19:03:17 [DEBUG] Sweeper (aws_opensearch_domain) has dependency (aws_opensearch_outbound_connection), running..
2024/08/19 19:03:17 [DEBUG] Running Sweeper (aws_opensearch_outbound_connection) in region (us-west-2)
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-058fa245-1996-48fc-ac74-3354ef0abed4: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-0ba70170-9ae7-4bec-9d97-560afe3b447a: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-1b4fe176-5a18-4d7e-bdac-72fdddbf933c: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-32448e60-02c5-4d7e-b731-9196fbd1dfbc: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-343d8cd3-dc40-473d-8264-c50ff0943474: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-3d8859f4-1e8a-4ab5-b2cf-efdc44e78c0f: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-443aa43c-9afd-4e78-bf6b-b4391457379f: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-4fbdfa16-259f-4185-b8e7-3d00f3e06bd4: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-5793a8e2-92b7-4d04-835a-cf6a16b76172: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-6183143a-66b8-494a-b081-80b319c43d14: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-6646f778-49d5-4971-9599-ebb5132c05bd: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-6a95c82d-fa03-415a-942c-0ae14d364d22: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-6e2041db-8b6f-469d-9330-f9245e8389cb: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-7e6a6b76-0df4-4a0c-b81a-85087684dd6b: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-7fb7d3f0-6f2c-4218-9059-86a09043027e: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-82eeb866-ca49-48b9-8faf-82c44c2f8931: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-87980723-119b-4784-baee-22c3f22f1ed2: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-909b9de6-bab0-456c-a38b-9d1954b3f592: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-936f0bbf-83bf-4e83-8ea8-b200f38a8568: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-b05e9f1c-6980-4d54-9915-4385437c8b8d: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-b6fe06a0-7ec0-46a6-a1b4-091fe17188e8: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-bcf5068a-53c3-430b-8bd9-b9e84b989b04: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-c6195fb7-30ad-44c4-8253-64ee98b9903f: DELETED
2024/08/19 19:03:18 [INFO] Skipping OpenSearch Outbound Connection cc-eb9a6d11-4b2e-47ca-8ad0-2d202ca6ee95: DELETED
2024/08/19 19:03:18 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:03:18 [DEBUG] Completed Sweeper (aws_opensearch_outbound_connection) in region (us-west-2) in 321.465667ms
2024/08/19 19:03:18 [DEBUG] Running Sweeper (aws_opensearch_domain) in region (us-west-2)
2024/08/19 19:03:18 [INFO]  sweeper: No resources to sweep: sweeper_region=us-west-2
2024/08/19 19:03:18 [DEBUG] Completed Sweeper (aws_opensearch_domain) in region (us-west-2) in 156.16175ms
2024/08/19 19:03:18 [DEBUG] Sweeper (aws_opensearch_outbound_connection) already ran in region (us-west-2)
2024/08/19 19:03:18 Completed Sweepers for region (us-west-2) in 1.908832583s
2024/08/19 19:03:18 Sweeper Tests for region (us-west-2) ran successfully:
2024/08/19 19:03:18     - aws_opensearch_inbound_connection_accepter
2024/08/19 19:03:18     - aws_opensearch_outbound_connection
2024/08/19 19:03:18     - aws_opensearch_domain
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      6.559s

ewbankkit
ewbankkit approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearch' PKG=opensearch ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearch/... -v -count 1 -parallel 4  -run=TestAccOpenSearch -timeout 720m
go: downloading github.com/aws/aws-sdk-go-v2/service/opensearch v1.39.3
=== RUN   TestAccOpenSearchDomainDataSource_Data_basic
=== PAUSE TestAccOpenSearchDomainDataSource_Data_basic
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchDomainPolicy_basic
=== PAUSE TestAccOpenSearchDomainPolicy_basic
=== RUN   TestAccOpenSearchDomainSAMLOptions_basic
=== PAUSE TestAccOpenSearchDomainSAMLOptions_basic
=== RUN   TestAccOpenSearchDomainSAMLOptions_disappears
=== PAUSE TestAccOpenSearchDomainSAMLOptions_disappears
=== RUN   TestAccOpenSearchDomainSAMLOptions_disappears_Domain
=== PAUSE TestAccOpenSearchDomainSAMLOptions_disappears_Domain
=== RUN   TestAccOpenSearchDomainSAMLOptions_Update
=== PAUSE TestAccOpenSearchDomainSAMLOptions_Update
=== RUN   TestAccOpenSearchDomainSAMLOptions_Disabled
=== PAUSE TestAccOpenSearchDomainSAMLOptions_Disabled
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_requireHTTPS
=== PAUSE TestAccOpenSearchDomain_requireHTTPS
=== RUN   TestAccOpenSearchDomain_customEndpoint
=== PAUSE TestAccOpenSearchDomain_customEndpoint
=== RUN   TestAccOpenSearchDomain_Cluster_zoneAwareness
=== PAUSE TestAccOpenSearchDomain_Cluster_zoneAwareness
=== RUN   TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN   TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== RUN   TestAccOpenSearchDomain_Cluster_update
=== PAUSE TestAccOpenSearchDomain_Cluster_update
=== RUN   TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== PAUSE TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== RUN   TestAccOpenSearchDomain_duplicate
=== PAUSE TestAccOpenSearchDomain_duplicate
=== RUN   TestAccOpenSearchDomain_v23
=== PAUSE TestAccOpenSearchDomain_v23
=== RUN   TestAccOpenSearchDomain_complex
=== PAUSE TestAccOpenSearchDomain_complex
=== RUN   TestAccOpenSearchDomain_VPC_basic
=== PAUSE TestAccOpenSearchDomain_VPC_basic
=== RUN   TestAccOpenSearchDomain_VPC_update
=== PAUSE TestAccOpenSearchDomain_VPC_update
=== RUN   TestAccOpenSearchDomain_VPC_internetToVPCEndpoint
=== PAUSE TestAccOpenSearchDomain_VPC_internetToVPCEndpoint
=== RUN   TestAccOpenSearchDomain_ipAddressType
=== PAUSE TestAccOpenSearchDomain_ipAddressType
=== RUN   TestAccOpenSearchDomain_autoTuneOptions
=== PAUSE TestAccOpenSearchDomain_autoTuneOptions
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
=== RUN   TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
=== PAUSE TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
=== RUN   TestAccOpenSearchDomain_CognitoOptions_createAndRemove
=== PAUSE TestAccOpenSearchDomain_CognitoOptions_createAndRemove
=== RUN   TestAccOpenSearchDomain_CognitoOptions_update
=== PAUSE TestAccOpenSearchDomain_CognitoOptions_update
=== RUN   TestAccOpenSearchDomain_Policy_basic
=== PAUSE TestAccOpenSearchDomain_Policy_basic
=== RUN   TestAccOpenSearchDomain_Policy_addPrincipal
=== PAUSE TestAccOpenSearchDomain_Policy_addPrincipal
=== RUN   TestAccOpenSearchDomain_Policy_ignoreEquivalent
=== PAUSE TestAccOpenSearchDomain_Policy_ignoreEquivalent
=== RUN   TestAccOpenSearchDomain_Encryption_atRestDefaultKey
=== PAUSE TestAccOpenSearchDomain_Encryption_atRestDefaultKey
=== RUN   TestAccOpenSearchDomain_Encryption_atRestSpecifyKey
=== PAUSE TestAccOpenSearchDomain_Encryption_atRestSpecifyKey
=== RUN   TestAccOpenSearchDomain_Encryption_atRestEnable
=== PAUSE TestAccOpenSearchDomain_Encryption_atRestEnable
=== RUN   TestAccOpenSearchDomain_Encryption_atRestEnableLegacy
=== PAUSE TestAccOpenSearchDomain_Encryption_atRestEnableLegacy
=== RUN   TestAccOpenSearchDomain_Encryption_nodeToNode
=== PAUSE TestAccOpenSearchDomain_Encryption_nodeToNode
=== RUN   TestAccOpenSearchDomain_Encryption_nodeToNodeEnable
=== PAUSE TestAccOpenSearchDomain_Encryption_nodeToNodeEnable
=== RUN   TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy
=== PAUSE TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy
=== RUN   TestAccOpenSearchDomain_offPeakWindowOptions
=== PAUSE TestAccOpenSearchDomain_offPeakWindowOptions
=== RUN   TestAccOpenSearchDomain_tags
=== PAUSE TestAccOpenSearchDomain_tags
=== RUN   TestAccOpenSearchDomain_VolumeType_update
=== PAUSE TestAccOpenSearchDomain_VolumeType_update
=== RUN   TestAccOpenSearchDomain_VolumeType_gp3ToGP2
=== PAUSE TestAccOpenSearchDomain_VolumeType_gp3ToGP2
=== RUN   TestAccOpenSearchDomain_VolumeType_missing
=== PAUSE TestAccOpenSearchDomain_VolumeType_missing
=== RUN   TestAccOpenSearchDomain_versionUpdate
=== PAUSE TestAccOpenSearchDomain_versionUpdate
=== RUN   TestAccOpenSearchDomain_softwareUpdateOptions
=== PAUSE TestAccOpenSearchDomain_softwareUpdateOptions
=== RUN   TestAccOpenSearchDomain_disappears
=== PAUSE TestAccOpenSearchDomain_disappears
=== RUN   TestAccOpenSearchInboundConnectionAccepter_basic
=== PAUSE TestAccOpenSearchInboundConnectionAccepter_basic
=== RUN   TestAccOpenSearchInboundConnectionAccepter_disappears
=== PAUSE TestAccOpenSearchInboundConnectionAccepter_disappears
=== RUN   TestAccOpenSearchOutboundConnection_basic
=== PAUSE TestAccOpenSearchOutboundConnection_basic
=== RUN   TestAccOpenSearchOutboundConnection_vpc
=== PAUSE TestAccOpenSearchOutboundConnection_vpc
=== RUN   TestAccOpenSearchOutboundConnection_disappears
=== PAUSE TestAccOpenSearchOutboundConnection_disappears
=== RUN   TestAccOpenSearchPackageAssociation_basic
=== PAUSE TestAccOpenSearchPackageAssociation_basic
=== RUN   TestAccOpenSearchPackageAssociation_disappears
=== PAUSE TestAccOpenSearchPackageAssociation_disappears
=== RUN   TestAccOpenSearchPackage_basic
=== PAUSE TestAccOpenSearchPackage_basic
=== RUN   TestAccOpenSearchPackage_disappears
=== PAUSE TestAccOpenSearchPackage_disappears
=== RUN   TestAccOpenSearchVPCEndpoint_basic
=== PAUSE TestAccOpenSearchVPCEndpoint_basic
=== RUN   TestAccOpenSearchVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchVPCEndpoint_disappears
=== RUN   TestAccOpenSearchVPCEndpoint_update
=== PAUSE TestAccOpenSearchVPCEndpoint_update
=== CONT  TestAccOpenSearchDomainDataSource_Data_basic
=== CONT  TestAccOpenSearchPackageAssociation_basic
=== CONT  TestAccOpenSearchVPCEndpoint_basic
=== CONT  TestAccOpenSearchVPCEndpoint_update
--- PASS: TestAccOpenSearchDomainDataSource_Data_basic (2113.20s)
=== CONT  TestAccOpenSearchPackage_basic
--- PASS: TestAccOpenSearchPackage_basic (21.78s)
=== CONT  TestAccOpenSearchPackage_disappears
--- PASS: TestAccOpenSearchPackage_disappears (19.25s)
=== CONT  TestAccOpenSearchVPCEndpoint_disappears
--- PASS: TestAccOpenSearchPackageAssociation_basic (2183.04s)
=== CONT  TestAccOpenSearchPackageAssociation_disappears
--- PASS: TestAccOpenSearchVPCEndpoint_update (2652.11s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
--- PASS: TestAccOpenSearchPackageAssociation_disappears (1879.04s)
=== CONT  TestAccOpenSearchOutboundConnection_disappears
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs (1754.32s)
=== CONT  TestAccOpenSearchOutboundConnection_vpc
--- PASS: TestAccOpenSearchVPCEndpoint_disappears (2343.32s)
=== CONT  TestAccOpenSearchOutboundConnection_basic
--- PASS: TestAccOpenSearchOutboundConnection_disappears (2026.87s)
=== CONT  TestAccOpenSearchInboundConnectionAccepter_disappears
--- PASS: TestAccOpenSearchOutboundConnection_basic (2087.79s)
=== CONT  TestAccOpenSearchInboundConnectionAccepter_basic
--- PASS: TestAccOpenSearchOutboundConnection_vpc (2526.51s)
=== CONT  TestAccOpenSearchDomain_disappears
--- PASS: TestAccOpenSearchInboundConnectionAccepter_disappears (2042.01s)
=== CONT  TestAccOpenSearchDomain_softwareUpdateOptions
--- PASS: TestAccOpenSearchDomain_disappears (1647.21s)
=== CONT  TestAccOpenSearchDomain_versionUpdate
--- PASS: TestAccOpenSearchInboundConnectionAccepter_basic (2028.58s)
=== CONT  TestAccOpenSearchDomain_VolumeType_missing
--- PASS: TestAccOpenSearchVPCEndpoint_basic (2621.78s)
=== CONT  TestAccOpenSearchDomain_VolumeType_gp3ToGP2
--- PASS: TestAccOpenSearchDomain_softwareUpdateOptions (1647.51s)
=== CONT  TestAccOpenSearchDomain_VolumeType_update
--- PASS: TestAccOpenSearchDomain_VolumeType_missing (1242.39s)
=== CONT  TestAccOpenSearchDomain_tags
--- PASS: TestAccOpenSearchDomain_VolumeType_gp3ToGP2 (1495.73s)
=== CONT  TestAccOpenSearchDomain_offPeakWindowOptions
--- PASS: TestAccOpenSearchDomain_tags (1813.85s)
=== CONT  TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy
--- PASS: TestAccOpenSearchDomain_versionUpdate (3352.86s)
=== CONT  TestAccOpenSearchDomain_Encryption_nodeToNodeEnable
--- PASS: TestAccOpenSearchDomain_offPeakWindowOptions (1483.66s)
=== CONT  TestAccOpenSearchDomain_Encryption_nodeToNode
--- PASS: TestAccOpenSearchDomain_VolumeType_update (3025.81s)
=== CONT  TestAccOpenSearchDomain_Encryption_atRestEnableLegacy
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNode (1237.48s)
=== CONT  TestAccOpenSearchDomain_Encryption_atRestEnable
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnable (3730.55s)
=== CONT  TestAccOpenSearchDomain_Encryption_atRestSpecifyKey
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnableLegacy (2875.61s)
=== CONT  TestAccOpenSearchDomain_Encryption_atRestDefaultKey
--- PASS: TestAccOpenSearchDomain_Encryption_nodeToNodeEnableLegacy (4610.51s)
=== CONT  TestAccOpenSearchDomain_Policy_ignoreEquivalent
--- PASS: TestAccOpenSearchDomain_Encryption_atRestSpecifyKey (1575.61s)
=== CONT  TestAccOpenSearchDomain_Policy_addPrincipal
--- PASS: TestAccOpenSearchDomain_Encryption_atRestDefaultKey (1582.22s)
=== CONT  TestAccOpenSearchDomain_Policy_basic
--- PASS: TestAccOpenSearchDomain_Encryption_atRestEnable (4053.61s)
=== CONT  TestAccOpenSearchDomain_CognitoOptions_update
--- PASS: TestAccOpenSearchDomain_Policy_ignoreEquivalent (1248.71s)
=== CONT  TestAccOpenSearchDomain_CognitoOptions_createAndRemove
--- PASS: TestAccOpenSearchDomain_Policy_basic (1242.49s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
--- PASS: TestAccOpenSearchDomain_Policy_addPrincipal (1324.66s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
--- PASS: TestAccOpenSearchDomain_CognitoOptions_update (1849.08s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
--- PASS: TestAccOpenSearchDomain_CognitoOptions_createAndRemove (1811.13s)
=== CONT  TestAccOpenSearchDomain_Cluster_update
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_auditLogs (1239.35s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs (1238.51s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs (1238.38s)
=== CONT  TestAccOpenSearchDomain_AdvancedSecurityOptions_userDB
--- PASS: TestAccOpenSearchDomain_Cluster_update (1359.32s)
=== CONT  TestAccOpenSearchDomain_autoTuneOptions
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_disabled (1237.05s)
=== CONT  TestAccOpenSearchDomain_ipAddressType
--- PASS: TestAccOpenSearchDomain_AdvancedSecurityOptions_anonymousAuth (4948.84s)
=== CONT  TestAccOpenSearchDomain_VPC_internetToVPCEndpoint
--- PASS: TestAccOpenSearchDomain_VPC_internetToVPCEndpoint (4255.35s)
=== CONT  TestAccOpenSearchDomain_VPC_update
--- PASS: TestAccOpenSearchDomain_VPC_update (1446.48s)
=== CONT  TestAccOpenSearchDomain_VPC_basic
--- PASS: TestAccOpenSearchDomain_VPC_basic (2322.45s)
=== CONT  TestAccOpenSearchDomain_complex
--- PASS: TestAccOpenSearchDomain_complex (3485.90s)
=== CONT  TestAccOpenSearchDomain_v23
--- PASS: TestAccOpenSearchDomain_v23 (1581.17s)
=== CONT  TestAccOpenSearchDomain_duplicate
--- PASS: TestAccOpenSearchDomain_duplicate (1159.53s)
=== CONT  TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (3031.41s)
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1268.81s)
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedMaster
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (1638.63s)
=== CONT  TestAccOpenSearchDomain_Cluster_warm
--- PASS: TestAccOpenSearchDomain_Cluster_warm (6276.03s)
=== CONT  TestAccOpenSearchDomain_customEndpoint
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (2071.19s)
=== CONT  TestAccOpenSearchDomain_requireHTTPS
--- PASS: TestAccOpenSearchDomain_customEndpoint (2123.29s)
=== CONT  TestAccOpenSearchDomainSAMLOptions_disappears
--- PASS: TestAccOpenSearchDomain_requireHTTPS (2115.16s)
=== CONT  TestAccOpenSearchDomainSAMLOptions_Disabled
--- PASS: TestAccOpenSearchDomainSAMLOptions_disappears (2203.60s)
=== CONT  TestAccOpenSearchDomainSAMLOptions_Update
--- PASS: TestAccOpenSearchDomainSAMLOptions_Disabled (2147.58s)
=== CONT  TestAccOpenSearchDomainSAMLOptions_disappears_Domain
--- PASS: TestAccOpenSearchDomainSAMLOptions_Update (2087.90s)
=== CONT  TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (3323.76s)
=== CONT  TestAccOpenSearchDomainPolicy_basic
--- PASS: TestAccOpenSearchDomainSAMLOptions_disappears_Domain (2068.68s)
=== CONT  TestAccOpenSearchDomainSAMLOptions_basic
--- PASS: TestAccOpenSearchDomainPolicy_basic (2310.94s)
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (1337.00s)
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (5053.41s)
--- PASS: TestAccOpenSearchDomainSAMLOptions_basic (2046.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	21465.847s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1956579 into hashicorp:main Aug 19, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 19, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Aug 26, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/opensearch Issues and PRs that pertain to the opensearch service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.63.1
2 participants
@DanielRieske @ewbankkit