td/Add tests to slot_type and fixes

[nam054]

Description

Add tests for composite_slot_type_setting as well as various fixes for naming errors and mix match.

Previously the nested argument sub_slots was misnamed. There was a discrepancy between between the struct and schema - when the current name in the schema is used this error would occur:

        Error: Unable to Convert Configuration
        
          with aws_lexv2models_slot_type.test,
          on terraform_plugin_test.tf line 62, in resource "aws_lexv2models_slot_type" "test":
          62: resource "aws_lexv2models_slot_type" "test" {
        
        An unexpected error was encountered when converting the configuration from
        the protocol type. This is always an issue in terraform-plugin-framework used
        to implement the provider and should be reported to the provider developers.
        
        Please report this to the provider developer:
        
        Unable to unmarshal DynamicValue:
        AttributeName("composite_slot_type_setting").ElementKeyInt(0): unknown
        attribute "subslots"

As such, though technically a break change, it is deemed acceptable within a minor release.

Relations

References

Output from Acceptance Testing

> make testacc TESTARGS="-run=TestAccLexV2ModelsSlotType_" PKG=lexv2models
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lexv2models/... -v -count 1 -parallel 20  -run=TestAccLexV2ModelsSlotType_ -timeout 360m
=== RUN   TestAccLexV2ModelsSlotType_basic
=== PAUSE TestAccLexV2ModelsSlotType_basic
=== RUN   TestAccLexV2ModelsSlotType_values
=== PAUSE TestAccLexV2ModelsSlotType_values
=== RUN   TestAccLexV2ModelsSlotType_disappears
=== PAUSE TestAccLexV2ModelsSlotType_disappears
=== RUN   TestAccLexV2ModelsSlotType_valueSelectionSetting
=== PAUSE TestAccLexV2ModelsSlotType_valueSelectionSetting
=== RUN   TestAccLexV2ModelsSlotType_compositeSlotTypeSetting
=== PAUSE TestAccLexV2ModelsSlotType_compositeSlotTypeSetting
=== CONT  TestAccLexV2ModelsSlotType_basic
=== CONT  TestAccLexV2ModelsSlotType_valueSelectionSetting
=== CONT  TestAccLexV2ModelsSlotType_compositeSlotTypeSetting
=== CONT  TestAccLexV2ModelsSlotType_values
=== CONT  TestAccLexV2ModelsSlotType_disappears
--- PASS: TestAccLexV2ModelsSlotType_compositeSlotTypeSetting (49.64s)
--- PASS: TestAccLexV2ModelsSlotType_valueSelectionSetting (49.70s)
--- PASS: TestAccLexV2ModelsSlotType_values (51.75s)
--- PASS: TestAccLexV2ModelsSlotType_basic (51.78s)
--- PASS: TestAccLexV2ModelsSlotType_disappears (52.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        58.422s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

Just needs a changelog.

% make testacc PKG=lexv2models TESTS=TestAccLexV2ModelsSlotType_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsSlotType_'  -timeout 360m

--- PASS: TestAccLexV2ModelsSlotType_compositeSlotTypeSetting (42.88s)
--- PASS: TestAccLexV2ModelsSlotType_valueSelectionSetting (42.91s)
--- PASS: TestAccLexV2ModelsSlotType_disappears (43.63s)
--- PASS: TestAccLexV2ModelsSlotType_values (43.84s)
--- PASS: TestAccLexV2ModelsSlotType_basic (45.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        51.940s

[github-actions]

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!