Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iam_role: improve inline_policy deprecation message #39430

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 20, 2024

Description

The updated deprecation message now includes the impacted argument name, providing clarity around what argument should be addressed.

│ Warning: Argument is deprecated
│
│   with aws_iam_role.test,
│   on main.tf line 33, in resource "aws_iam_role" "test":
│   33: resource "aws_iam_role" "test" {
│
│ The inline_policy argument is deprecated. Use the aws_iam_role_policy resource instead. If Terraform should exclusively manage all inline policy associations (the current behavior
│ of this argument), use the aws_iam_role_policies_exclusive resource as well.

Also updates the registry documentation to include deprecation warnings above the inline_policy examples.

Relations

Relates #39203
Relates #22336

The updated deprecation message now includes the impacted argument name,
providing clarity around what argument should be addressed.

```
│ Warning: Argument is deprecated
│
│   with aws_iam_role.test,
│   on main.tf line 33, in resource "aws_iam_role" "test":
│   33: resource "aws_iam_role" "test" {
│
│ The inline_policy argument is deprecated. Use the aws_iam_role_policy resource instead. If Terraform should exclusively manage all inline policy associations (the current behavior
│ of this argument), use the aws_iam_role_policies_exclusive resource as well.
```
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 20, 2024
@jar-b jar-b marked this pull request as ready for review September 20, 2024 20:36
@jar-b jar-b requested a review from a team as a code owner September 20, 2024 20:36
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 9180a8b into main Sep 23, 2024
50 checks passed
@jar-b jar-b deleted the d-inline-policy-deprecation branch September 23, 2024 13:31
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants