Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for OpenSearch Serverless VPCE test #39454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mumoumit
Copy link

Description

There was a bug in the test code. When I ran the Acceptance test for VPCE I got this error:

make testacc TESTS=TestAccOpenSearchServerlessVPCEndpoint PKG=opensearchserverless
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessVPCEndpoint'  -timeout 360m
=== RUN   TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_basic
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_update
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_update
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT  TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_update
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_basic
=== NAME  TestAccOpenSearchServerlessVPCEndpoint_securityGroups
    vpc_endpoint_test.go:72: Step 1/3 error: Check failed: Check 2/2 error: aws_opensearchserverless_vpc_endpoint.test: Attribute 'security_group_ids.#' not found
=== NAME  TestAccOpenSearchServerlessVPCEndpoint_basic
    vpc_endpoint_test.go:35: Step 1/2 error: Check failed: Check 3/3 error: aws_opensearchserverless_vpc_endpoint.test: Attribute 'security_group_ids.#' expected to be set
=== NAME  TestAccOpenSearchServerlessVPCEndpoint_update
    vpc_endpoint_test.go:118: Step 1/4 error: Check failed: Check 3/3 error: aws_opensearchserverless_vpc_endpoint.test: Attribute 'security_group_ids.#' not found
--- FAIL: TestAccOpenSearchServerlessVPCEndpoint_update (298.38s)
--- FAIL: TestAccOpenSearchServerlessVPCEndpoint_securityGroups (298.77s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_disappears (305.24s)
--- FAIL: TestAccOpenSearchServerlessVPCEndpoint_basic (338.38s)
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (343.69s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless     343.864s
FAIL
make: *** [testacc] Error 1

Relations

N/A

References

Output from Acceptance Testing

% make testacc TESTS=TestAccOpenSearchServerlessVPCEndpoint PKG=opensearchserverless
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessVPCEndpoint'  -timeout 360m
=== RUN   TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_basic
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_basic
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_securityGroups
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_update
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_update
=== RUN   TestAccOpenSearchServerlessVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT  TestAccOpenSearchServerlessVPCEndpointDataSource_basic
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_update
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_basic
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_disappears
=== CONT  TestAccOpenSearchServerlessVPCEndpoint_securityGroups
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_basic (326.96s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_disappears (332.66s)
--- PASS: TestAccOpenSearchServerlessVPCEndpointDataSource_basic (334.52s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_securityGroups (404.37s)
--- PASS: TestAccOpenSearchServerlessVPCEndpoint_update (519.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless 519.529s

@mumoumit mumoumit requested a review from a team as a code owner September 23, 2024 20:24
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants