Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TechDebt]: Remove use of errs.Must within service packages #39456

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

[TechDebt]: Remove use of errs.Must within service packages #39456

wants to merge 31 commits into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 23, 2024

Description

This check will match on any use of errs.Must(...) within internal/service/**/. Errors should be handled explicitly in service packages to avoid the possibility of crashing the provider during execution. This function was originally intended for use while initializing service clients during the ConfigureProvider operation, where a panic is the appropriate course of action.

Relations

Closes #39038

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@jar-b
ci(semgrep): add avoid-errs-Must check
b2a90dd 
This check will match on any use of `errs.Must(...)` within `internal/service/**/`. Errors should be handled explicitly in service packages to avoid the possibility of crashing the provider during execution. This function was originally intended for use while initializing service clients during the `ConfigureProvider` operation, where a panic is the appropriate course of action.
@jar-b
account: remove use of errs.Must
80cff39
@jar-b
acmpca: remove use of errs.Must
5ec60d7
@jar-b
appfabric: remove use of errs.Must
4796c3d
@jar-b
appsync: remove use of errs.Must
f0af587
@jar-b
bedrockagent: remove use of errs.Must
d6c963a
@jar-b
cloudformation: remove use of errs.Must
2f4d165
@jar-b
cloudfrontkeyvaluestore: remove use of errs.Must
fb585d3
@jar-b
cognitoidp: remove use of errs.Must
827a653
@jar-b
computeoptimizer: remove use of errs.Must
72227b5
@jar-b
connect: remove use of errs.Must
b1b327e
@jar-b
controltower: remove use of errs.Must
648d236
@jar-b
dynamodb: remove use of errs.Must
5f2c57d
@jar-b
ec2: remove use of errs.Must
dc661f8
@jar-b
elasticache: remove use of errs.Must
a60a4c3
@jar-b
elbv2: remove use of errs.Must
542d374
@jar-b
fms: remove use of errs.Must
1139e1b
@jar-b
grafana: remove use of errs.Must
be8660d
@jar-b
lambda: remove use of errs.Must
4e3311c
@jar-b
lexv2models: remove use of errs.Must
531b27a
@jar-b
m2: remove use of errs.Must
fa9e28c
@jar-b
networkmonitor: remove use of errs.Must
39472df
@jar-b
ram: remove use of errs.Must
812783d
@jar-b
redshiftserverless: remove use of errs.Must
467d843
@jar-b
route53: remove use of errs.Must
43ecdf5
@jar-b
route53domains: remove use of errs.Must
2464f4c
@jar-b
s3control: remove use of errs.Must
c57715f
@jar-b
securityhub: remove use of errs.Must
b9fe388
@jar-b
securitylake: remove use of errs.Must
e3bce7d
@jar-b
ssm: remove use of errs.Must
41b0eea
@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ssm Issues and PRs that pertain to the ssm service. service/appsync Issues and PRs that pertain to the appsync service. service/elasticache Issues and PRs that pertain to the elasticache service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/route53domains Issues and PRs that pertain to the route53domains service. service/fms Issues and PRs that pertain to the fms service. service/acmpca Issues and PRs that pertain to the acmpca service. service/connect Issues and PRs that pertain to the connect service. service/s3control Issues and PRs that pertain to the s3control service. service/ram Issues and PRs that pertain to the ram service. service/securityhub Issues and PRs that pertain to the securityhub service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. service/account Issues and PRs that pertain to the account service. service/grafana Issues and PRs that pertain to the grafana service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/controltower Issues and PRs that pertain to the controltower service. service/securitylake Issues and PRs that pertain to the securitylake service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/appfabric Issues and PRs that pertain to the appfabric service. service/m2 Issues and PRs that pertain to the m2 service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/account Issues and PRs that pertain to the account service. service/acmpca Issues and PRs that pertain to the acmpca service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appsync Issues and PRs that pertain to the appsync service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/connect Issues and PRs that pertain to the connect service. service/controltower Issues and PRs that pertain to the controltower service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/fms Issues and PRs that pertain to the fms service. service/grafana Issues and PRs that pertain to the grafana service. service/lambda Issues and PRs that pertain to the lambda service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/m2 Issues and PRs that pertain to the m2 service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. service/ram Issues and PRs that pertain to the ram service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53 Issues and PRs that pertain to the route53 service. service/s3control Issues and PRs that pertain to the s3control service. service/securityhub Issues and PRs that pertain to the securityhub service. service/securitylake Issues and PRs that pertain to the securitylake service. service/ssm Issues and PRs that pertain to the ssm service. service/wafv2 Issues and PRs that pertain to the wafv2 service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TechDebt]: Reduce use of errs.Must
1 participant
@jar-b