Test creation on Consul cluster root token #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the root token has a no-op for reading the resource, we only create the token to ensure that it does not error upon creation.
bcmdarroch
reviewed
Jun 10, 2021
| // to shorten testing time. | ||
| // This includes tests against both the resource, the corresponding datasource, | ||
| // and creation of the Consul cluster root token resource in order to shorten | ||
| // testing time. |
There was a problem hiding this comment.
Could we add some assertions below on the root token output? (accessor_id, secret_id, and kubernetes_secret)
There was a problem hiding this comment.
Tests results after updates:
$ make testacc TESTARGS='-run=TestAccConsulCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccConsulCluster -timeout 120m
? github.com/hashicorp/terraform-provider-hcp/internal/clients [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/consul 0.692s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/input 1.422s [no tests to run]
=== RUN TestAccConsulCluster
--- PASS: TestAccConsulCluster (582.54s)
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/provider 583.039s
bcmdarroch
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Because the root token has a no-op for reading the resource, we only
create the token to ensure that it does not error upon creation.
🏗️ Acceptance tests
Output from acceptance testing: