Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: just WARN about missing HCP Consul client configs #345

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix: just WARN about missing HCP Consul client configs #345

merged 1 commit into from
Jul 7, 2022

Conversation

jjti
Copy link
Contributor

@jjti jjti commented Jul 6, 2022 •
edited
Loading

🛠️ Description

This is a small change so the HCP Consul TF providers don't fail out when they fail to get client configs.. as will be the case for FAILED clusters. Instead, we report the failure and leave the state of the client config unchanged.

🚢 Release Note

Release note for CHANGELOG:

* resource_consul_cluster: only WARN on failed client config calls [GH-345]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@jjti jjti marked this pull request as ready for review July 6, 2022 16:51
@jjti jjti requested a review from a team as a code owner July 6, 2022 16:51
@jjti jjti requested review from a team and bcmdarroch July 6, 2022 16:51
@jjti jjti changed the title Fix to just WARN about missing client configs Fix to just WARN about missing HCP Consul client configs Jul 6, 2022
@jjti jjti changed the title Fix to just WARN about missing HCP Consul client configs Fix: just WARN about missing HCP Consul client configs Jul 6, 2022
@jjti jjti merged commit 780b24c into main Jul 7, 2022
@jjti jjti deleted the jjtimmons/warn-on-missing-client-cfg branch July 7, 2022 16:05
aidan-mundy pushed a commit that referenced this pull request Sep 8, 2023
@bcmdarroch
Fix to just WARN about missing client configs (#345)
7c76f1c 
- otherwise this fails out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riddhi89 riddhi89 riddhi89 approved these changes

@bcmdarroch bcmdarroch bcmdarroch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjti @riddhi89 @bcmdarroch