Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for HCP Boundary #378

Merged
merged 10 commits into from
Aug 26, 2022

Conversation

rizkybiz
Copy link
Contributor

@rizkybiz rizkybiz commented Aug 22, 2022

🛠️ Description

  • Added support for creating an HCP Boundary cluster via Terraform
  • Added docs for HCP Boundary resource and data source
  • Updated hcp-sdk-go imports promoting consul to stable channel

🚢 Release Note

Release note for CHANGELOG:

* provider: Added support for HCP Boundary Beta clusters

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccBoundaryCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccBoundaryCluster -timeout 210m
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    0.495s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     0.841s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      0.727s [no tests to run]
=== RUN   TestAccBoundaryCluster
--- PASS: TestAccBoundaryCluster (114.96s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   115.455s

@rizkybiz rizkybiz requested a review from a team as a code owner August 22, 2022 20:41
@rizkybiz rizkybiz requested a review from a team August 22, 2022 20:41
@rizkybiz rizkybiz requested a review from a team as a code owner August 22, 2022 20:41
docs/resources/boundary_cluster.md Outdated Show resolved Hide resolved
Copy link
Contributor

@xargs-P xargs-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The password stuff is resolved ..

Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉 Looks great to me!

RE: the dependency CI issue, I've done the bump in a separate PR as a work-around: #381

internal/provider/resource_boundary_cluster.go Outdated Show resolved Hide resolved
internal/clients/client.go Outdated Show resolved Hide resolved
@rizkybiz rizkybiz requested a review from a team August 25, 2022 18:06
@rizkybiz rizkybiz requested a review from a team as a code owner August 25, 2022 18:06
Copy link

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bcmdarroch
Copy link
Contributor

Quick test run after rebase shenanigans:

make testacc TESTARGS='-run=TestAccBoundaryCluster'

--- PASS: TestAccBoundaryCluster (146.49s)
PASS

🎉

@bcmdarroch bcmdarroch merged commit 6b2235f into hashicorp:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants