Refactor HCP Vault TF acceptance tests for Azure

[codergs]

This PR adds acceptance tests with Azure cloud provider. Not all features are available under Azure cloud.

refactor is done so that we can use same code base for AWS And Azure cloud
separated out perf replication tests to a separate file - no refactor is done for this at the moment.
fixed a regression on perf replication test suites

🛠️ Description

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

Wed Oct 12 16:48:43 EDT 2022 hashicorp/terraform-provider-hcp-internal - (codergs-HVT-2273) > TF_LOG_PATH=out.text TF_LOG=TRACE TF_ACC=1 go test ./internal/... -parallel 20 -v -run=TestAccVaultClusterAWS -timeout 210m     
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
=== RUN   TestAccVaultClusterAWS
=== PAUSE TestAccVaultClusterAWS
=== CONT  TestAccVaultClusterAWS
--- PASS: TestAccVaultClusterAWS (2630.25s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   2630.911s

[hashicorp-cla]

All committers have signed the CLA.

[aoripov]

@bcmdarroch I ran the tests locally:

~/projects/terraform-provider-hcp (codergs-HVT-2273)$ TF_LOG_PATH=out.text TF_LOG=TRACE TF_ACC=1 go test ./internal/... -parallel 20 -v -run=TestAccVaultClusterAWS -timeout 210m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/clients	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccVaultClusterAWS
=== PAUSE TestAccVaultClusterAWS
=== CONT  TestAccVaultClusterAWS
--- PASS: TestAccVaultClusterAWS (4451.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	4452.169s

[codergs]

@aoripov @bcmdarroch can I please trouble you with azure tests too?

[aoripov]

Azure tests:

TF_LOG_PATH=out.main.text TF_LOG=TRACE TF_ACC=1 go test ./internal/... -parallel 20 -v -run=TestAccVaultClusterAzure -timeout 240m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/clients	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccVaultClusterAzure
=== PAUSE TestAccVaultClusterAzure
=== CONT  TestAccVaultClusterAzure
--- PASS: TestAccVaultClusterAzure (4493.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	4494.746s

[aoripov]

AWS tests.
Ignore failure. It failed on the last step of deleting an HVN because of an increased cadence latency.

TF_LOG_PATH=out.main.text TF_LOG=TRACE TF_ACC=1 go test ./internal/... -parallel 20 -v -run=TestAccVaultClusterAWS -timeout 240m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/clients	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccVaultClusterAWS
=== PAUSE TestAccVaultClusterAWS
=== CONT  TestAccVaultClusterAWS
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: unable to delete HVN (test-hvn-aws-202301251324): context canceled waiting for delete HVN operation (5a81e5f1-b4b8-4a46-b801-8ef0fdb42c8b) to complete

--- FAIL: TestAccVaultClusterAWS (7092.17s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-hcp/internal/provider	7092.827s
FAIL

[aoripov]

Performance replication tests. Same as with AWS tests they failed on the very last step - HVN deletion.

TF_LOG_PATH=repl.1.text TF_LOG=TRACE TF_ACC=1 go test ./internal/... -parallel 20 -v -run=TestAccPerformanceReplication_ValidationsAws -timeout 240m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/clients	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccPerformanceReplication_ValidationsAws
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: unable to delete HVN (test-perf-hvn-2-202301251411): context canceled waiting for delete HVN operation (43daf7c0-f1bf-4e0f-a4d4-43bd64e6b9b5) to complete


        Error: unable to delete HVN (test-perf-hvn-1-202301251411): context canceled waiting for delete HVN operation (0e0d2f89-c6d1-4e80-bab5-b594a387f9f6) to complete

--- FAIL: TestAccPerformanceReplication_ValidationsAws (12984.60s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-hcp/internal/provider	12985.886s
FAIL

[codergs]

LGTM, thanks for the testing.

[bcmdarroch]

Did one final test and all the Vault tests passed. Thanks for fixing those IDs!