Add new data source for HCP Vault #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sync'd fork with main and ran tests locally again ✅ $ git rev-parse HEAD
dd70d31d5c040e7abe868cb0a8502e0b0d20cdab
$ make testacc TESTARGS='-run=TestAcc_dataSourceVaultSecretsApp'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml
TF_ACC=1 go test ./internal/... -v -run=TestAcc_dataSourceVaultSecretsApp -timeout 360m -parallel=10
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/clients 0.678s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/consul 0.397s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/input 0.475s [no tests to run]
=== RUN TestAcc_dataSourceVaultSecretsApp
--- PASS: TestAcc_dataSourceVaultSecretsApp (9.34s)
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/provider 10.012s |
aidan-mundy
reviewed
Jun 10, 2023
| client := meta.(*clients.Client) | ||
| loc := &sharedmodels.HashicorpCloudLocationLocation{ | ||
| OrganizationID: client.Config.OrganizationID, | ||
| ProjectID: client.Config.ProjectID, |
There was a problem hiding this comment.
The provider now has first-class support for multi-project, which includes a pattern where individual resources should support an Optional project_id attribute. This new data source should probably also support that pattern.
andrey-donelli
approved these changes
Jun 13, 2023
byronwolfman
approved these changes
Jun 13, 2023
aidan-mundy
added a commit
that referenced
this pull request
Jun 20, 2023
commit d4aa0c6 Author: delores-hashicorp <109518991+delores-hashicorp@users.noreply.github.com> Date: Tue Jun 20 17:00:06 2023 +0200 [HCPF-644] Add more details to `project_id` description. (#527) Add more details to project_id description. commit 5b70411 Author: Judith Malnick <judith@hashicorp.com> Date: Fri Jun 16 14:06:21 2023 -0700 [docs] Fix link to architecture image now that cloud website has moved (#530) * fix link to architecture image now that cloud website has moved * add changes to template, remove dimiensions, generate docs commit 2173a20 Author: Aidan Mundy <aidan.mundy@hashicorp.com> Date: Tue Jun 13 11:20:47 2023 -0400 Fix missing CHANGELOG entry commit 08a0a25 Author: Austin Valle <austinvalle@gmail.com> Date: Tue Jun 13 09:23:55 2023 -0400 Add new data source for HCP Vault (#524) * Add new data source * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
🛠️ Description
Adds a new data source for HCP Vault for retrieving secrets
🏗️ Acceptance tests
Output from acceptance testing: