Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPR-1170: Add hcp_packer_bucket_names data source. #536

Merged
merged 11 commits into from
Jul 3, 2023

Conversation

aidan-mundy
Copy link
Contributor

@aidan-mundy aidan-mundy commented Jun 22, 2023

🛠️ Description

  • Adds hcp_packer_bucket_names data source.
  • Adds documentation for more automated management of channels.

🏗️ Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc.*PackerBucket.* -test.v'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAcc.*PackerBucket.* -test.v -timeout 360m -parallel=10
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
=== RUN   TestAcc_dataSourcePackerBucketNames
--- PASS: TestAcc_dataSourcePackerBucketNames (21.94s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   22.467s

@aidan-mundy aidan-mundy added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 22, 2023
Base automatically changed from HPR-1121/enhanced-channel-management to main June 26, 2023 15:06
@aidan-mundy aidan-mundy force-pushed the HPR-1170/bucket-names-resource branch from 55cabf4 to 3c59c21 Compare June 26, 2023 15:12
@aidan-mundy aidan-mundy marked this pull request as ready for review June 26, 2023 15:16
@aidan-mundy aidan-mundy requested a review from a team as a code owner June 26, 2023 15:16
docs/data-sources/packer_bucket_names.md Show resolved Hide resolved
docs/guides/packer-channel-management.md Outdated Show resolved Hide resolved
docs/guides/packer-channel-management.md Outdated Show resolved Hide resolved
docs/guides/packer-channel-management.md Show resolved Hide resolved
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM!

docs/guides/packer-channel-management.md Show resolved Hide resolved
docs/guides/packer-channel-management.md Show resolved Hide resolved
@aidan-mundy aidan-mundy merged commit 35d9922 into main Jul 3, 2023
5 checks passed
@aidan-mundy aidan-mundy deleted the HPR-1170/bucket-names-resource branch July 3, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants