Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case insensitive HCP Boundary tier configuration #554

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Case insensitive HCP Boundary tier configuration #554

merged 2 commits into from
Jul 13, 2023

Conversation

uruemu
Copy link
Contributor

@uruemu uruemu commented Jul 13, 2023

🛠️ Description

Builds upon #544. Makes the tier configration case insensitive

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@uruemu uruemu requested a review from a team as a code owner July 13, 2023 20:36
ajayreshc
ajayreshc approved these changes Jul 13, 2023
View reviewed changes
Copy link

@ajayreshc ajayreshc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uruemu uruemu merged commit e786346 into main Jul 13, 2023
5 checks passed
@uruemu uruemu deleted the uruemu/ICU-9830 branch July 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayreshc ajayreshc ajayreshc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uruemu @ajayreshc