Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service principal and service principal key resource/data source #636

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 16, 2023

🛠️ Description

Adds the following:

  • A hcp_service_principal resource
  • A hcp_service_principal data source
  • A hcp_service_principal_key resource

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality? No
  • Have you added an acceptance test for the functionality being added? Yes
  • Have you run the acceptance tests on this branch? Yes

Output from acceptance testing:

$ make testacc TESTARGS='-run="TestAccServicePrincipal"'
TF_ACC=1 go test ./internal/... -v -run="TestAccServicePrincipal" -timeout 360m -parallel=10
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    0.518s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     0.693s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator       0.336s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      0.440s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   0.390s [no tests to run]
=== RUN   TestAccServicePrincipalDataSource
--- PASS: TestAccServicePrincipalDataSource (10.28s)
=== RUN   TestAccServicePrincipalKeyResource
--- PASS: TestAccServicePrincipalKeyResource (34.70s)
=== RUN   TestAccServicePrincipalResource_Project
--- PASS: TestAccServicePrincipalResource_Project (17.94s)
=== RUN   TestAccServicePrincipalResource_ExplicitProject
--- PASS: TestAccServicePrincipalResource_ExplicitProject (9.59s)
=== RUN   TestAccServicePrincipalResource_Organization
--- PASS: TestAccServicePrincipalResource_Organization (10.80s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/iam       84.105s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   0.731s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      0.409s [no tests to run]

@dadgar dadgar requested a review from a team October 16, 2023 21:17
@dadgar dadgar requested a review from a team as a code owner October 16, 2023 21:17
@dadgar dadgar requested review from aidan-mundy and removed request for a team, codergs and jaireddjawed October 16, 2023 21:21
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@rselbach rselbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@dadgar dadgar merged commit cf031f9 into main Oct 17, 2023
6 checks passed
@dadgar dadgar deleted the f-service-principal branch October 17, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants