Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project import #642

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fix project import #642

merged 3 commits into from
Oct 18, 2023

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 18, 2023 •
edited
Loading

🛠️ Description

Fixes a bug in project import where it was setting the resource_name instead of the resource_id

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ TF_ACC=1 go test -v -run TestAccProjectResource
=== RUN   TestAccProjectResource
--- PASS: TestAccProjectResource (21.89s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   22.301s

dadgar
dadgar commented Oct 18, 2023
View reviewed changes
docs/resources/project.md
@@ -44,7 +44,4 @@ Import is supported using the following syntax:
```shell
# Project can be imported by specifying the project id
terraform import hcp_project.example 840e3701-55b6-4f86-8c17-b1fe397303c5

# Project can be imported by specifying the project resource name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not actually supported

@dadgar dadgar merged commit dad1e2c into main Oct 18, 2023
6 checks passed
@dadgar dadgar deleted the f-fix-project-import branch October 18, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidan-mundy aidan-mundy aidan-mundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadgar @aidan-mundy