Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some workload identity examples #657

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix some workload identity examples #657

merged 3 commits into from
Oct 26, 2023

Conversation

mpminardi
Copy link
Contributor

@mpminardi mpminardi commented Oct 26, 2023 •
edited
Loading

🛠️ Description

Fixes workload identity examples to use proper values conditional_access and allowed_audiences.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

@mpminardi mpminardi self-assigned this Oct 26, 2023
@mpminardi mpminardi marked this pull request as ready for review October 26, 2023 17:50
@mpminardi mpminardi requested review from a team as code owners October 26, 2023 17:50
@mpminardi mpminardi merged commit ac721d3 into main Oct 26, 2023
6 checks passed
@mpminardi mpminardi deleted the mpminardi/workload-identity-examples-fix branch October 26, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadgar dadgar dadgar approved these changes

@dgregoire dgregoire dgregoire approved these changes

Assignees

@mpminardi mpminardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpminardi @dadgar @dgregoire