Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFACE-2396: Add HCP Log Streaming Destination #713

Merged
merged 11 commits into from
Jan 8, 2024

Conversation

leahrob
Copy link
Contributor

@leahrob leahrob commented Dec 20, 2023

๐Ÿ› ๏ธ Description

add hcp_log_streaming_destination resource with splunk config IFACE-2431 IFACE-2396

๐Ÿ—๏ธ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

TestAccHCPLogStreamingDestinationSplunk
$ make testacc TESTARGS='-run=TestAccHCPLogStreamingDestinationSplunk'

==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAccHCPLogStreamingDestinationSplunk -timeout 360m -parallel=10
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/iampolicy  [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/iam       (cached) [no tests to run]
=== RUN   TestAccHCPLogStreamingDestinationSplunk
--- PASS: TestAccHCPLogStreamingDestinationSplunk (5.79s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      6.292s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/vaultsecrets      (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      (cached) [no tests to run]
...

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

@leahrob leahrob requested review from a team, mhaggerty042 and janet December 20, 2023 17:22
@leahrob leahrob force-pushed the IFACE-2396-add-splunk-streaming-destination branch from 946eba1 to 6711d24 Compare January 8, 2024 16:49
@leahrob leahrob marked this pull request as ready for review January 8, 2024 18:11
@leahrob leahrob requested a review from a team as a code owner January 8, 2024 18:11
Copy link
Contributor

@manish-hashicorp manish-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping based on @mhaggerty042 approval.

@manish-hashicorp
Copy link
Contributor

@leahrob I presume you are following the guide. Either way, remember to make a release after merging this. We are not doing it on regular basis.

@leahrob leahrob merged commit bdd7352 into main Jan 8, 2024
6 checks passed
@leahrob leahrob deleted the IFACE-2396-add-splunk-streaming-destination branch January 8, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants