Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: Waypoint TFC Config #766

Merged
merged 7 commits into from
Feb 29, 2024
Merged

New Resource: Waypoint TFC Config #766

merged 7 commits into from
Feb 29, 2024

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Feb 27, 2024

๐Ÿ› ๏ธ Description

๐Ÿ—๏ธ Acceptance tests

  • Are there any feature flags that are required to use this functionality? (No)
  • Have you added an acceptance test for the functionality being added? (Yes)
  • Have you run the acceptance tests on this branch? (Yes, locally)

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccWaypointTfcConfig_basic"
=== RUN   TestAccWaypointTfcConfig_basic
--- PASS: TestAccWaypointTfcConfig_basic (2.80s)

@catsby catsby requested a review from a team as a code owner February 27, 2024 22:20
@catsby catsby changed the title Hcp waypoint int New Resource: Waypoint TFC Config Feb 28, 2024
Copy link
Contributor

@manish-hashicorp manish-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping. Please get approval from another team member before merging.

@catsby
Copy link
Contributor Author

catsby commented Feb 28, 2024

Rubber stamping. Please get approval from another team member before merging.

Thanks @manish-hashicorp . Are you requesting another approval from someone on the team that owns this provider, or from another member of the Waypoint team? Thanks :D

@manish-hashicorp
Copy link
Contributor

Sorry should've been clear. I meant another approval from Waypoint team.

Copy link
Contributor

@HenryEstberg HenryEstberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* main:
  Bump github.com/go-openapi/strfmt from 0.22.0 to 0.22.1 (#768)
@catsby catsby merged commit 62e7c89 into main Feb 29, 2024
6 checks passed
@catsby catsby deleted the hcp-waypoint-int branch February 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants