generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Group Resource #772
Merged
JolisaBrownHashiCorp
merged 10 commits into
iam-groups-resources-hcpie-1016
from
group-resource-hcpie-1022
Mar 13, 2024
Merged
Add Group Resource #772
JolisaBrownHashiCorp
merged 10 commits into
iam-groups-resources-hcpie-1016
from
group-resource-hcpie-1022
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjaspermilan
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left some comments for you to take a look at π
JolisaBrownHashiCorp
force-pushed
the
group-resource-hcpie-1022
branch
from
March 4, 2024 19:07
57c887b
to
b6c3c19
Compare
squaresurf
reviewed
Mar 4, 2024
squaresurf
approved these changes
Mar 6, 2024
squaresurf
reviewed
Mar 6, 2024
itsjaspermilan
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!
squaresurf
requested changes
Mar 12, 2024
squaresurf
reviewed
Mar 12, 2024
JolisaBrownHashiCorp
force-pushed
the
group-resource-hcpie-1022
branch
from
March 13, 2024 16:00
308ceeb
to
7a46ae1
Compare
squaresurf
approved these changes
Mar 13, 2024
JolisaBrownHashiCorp
merged commit Mar 13, 2024
7ad89d1
into
iam-groups-resources-hcpie-1016
5 checks passed
squaresurf
pushed a commit
that referenced
this pull request
Mar 14, 2024
* define group resource * group resource implementation * group resource test coverage * syntax, validation tweaks * add docs - group resource * add docs - group data source * revise schema constraints * cleanup docs/comments * add pre-destroy check to test coverage/update docs * create group before fetching in datasource test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π οΈ Description
This PR includes changes to implement a groups resource and test coverage. This implementation is dependent on IAM sdk upgrades to grpc-gateway 2 in this PR.
π Relevant Links
Jira ποΈ : Resource: Group - HCPIE-1022
ποΈ Acceptance tests
This implementation is dependent on IAM sdk updates under review in this PR. To test these changes on PRDE, point your local cloud-iam build to the implementation of the checked out branch
f-gateway
.Next ensure that an organization level
HCP_CLIENT_ID
andHCP_CLIENT_SECRET
are set in your PRDE environment, as well as theHCP_API_ADDRESS
,HCP_AUTH_URL
,HCP_PROJECT_ID
, andHCP_OAUTH_CLIENT_ID
. Set the environment variableHCP_API_TLS
to disabled.Output from acceptance testing: