Add hcp_group_members resource

[squaresurf]

🛠️ Description

Jira: https://hashicorp.atlassian.net/browse/HCPIE-1023

The resource hcp_group_members allows users to manage the members in an hcp_group (resource/data source are added in another PR).

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality? No
• Have you added an acceptance test for the functionality being added? Yes
• Have you run the acceptance tests on this branch? Yes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccGroupMembersResource'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml
TF_ACC=1 go test ./internal/... -v -run=TestAccGroupMembersResource -timeout 360m -parallel=10
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/iampolicy  [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv1   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/customtypes       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/modifiers [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer    [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils  [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder    [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder/packerconfig       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testclient       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testcheck        [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils      [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/base [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/location     [no test files]
authznew "github.com/hashicorp/cloud-resource-manager/pkg/authz"
=== RUN   TestAccGroupMembersResource
--- PASS: TestAccGroupMembersResource (17.73s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/iam       18.240s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      0.712s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/artifact   0.980s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/version    1.166s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   0.704s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/vaultsecrets      0.447s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/webhook   0.920s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/webhook/validator (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      1.147s [no tests to run]

[itsjaspermilan]

Nice work! Approving for now but left some small comments 🙂

[itsjaspermilan]

Feel free to ignore this one, thought it might make things more clear!

Suggested change

	"iam/organization/<organization_id>/group/<name>"),
	"iam/organization/<organization_id>/group/<resource_name>"),

[squaresurf]

Hmm, I nearly did that, but thought that a resource_name was that whole path 🤔 . Should I replace the whole path with <resource_name>?

[itsjaspermilan]

That's a good question! I think maybe we can follow how we label it in the portal? If to the user a resource_name is the full iam/organization/<organization_id>/group/<name> then I think we can leave it as is. 🤔

[JolisaBrownHashiCorp]

It might help to add a comment that this group lives in the int tooling account just for documentation/readability.

[squaresurf]

I'll add a comment here. I did have a bit of a comment here for a while, then realized this is a public repo and we may not want to reveal too much.