Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCPIE-1016: Adding and adjusting subcategories for IAM stuff #797

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

itsjaspermilan
Copy link
Contributor

@itsjaspermilan itsjaspermilan commented Mar 22, 2024

🛠️ Description

Updates the subcategories for various IAM resources and data sources.

Output from Acc Testing

>make testacc TESTARGS='-run=TestAccUserPrincipalDataSource'
=== RUN   TestAccUserPrincipalDataSource
--- PASS: TestAccUserPrincipalDataSource (8.98s)
>make testacc TESTARGS='-run=TestAccGroupDataSource'        
=== RUN   TestAccGroupDataSource
--- PASS: TestAccGroupDataSource (7.89s)

@itsjaspermilan itsjaspermilan requested review from a team as code owners March 22, 2024 19:39
@squaresurf
Copy link
Member

Regarding this:

image

We saw the docs changes were approved so we tried to remove the extra commits to get back approval and to open a new PR, but it seems this is an edge case for GitHub where the history is also kinda odd and backwards.

@itsjaspermilan itsjaspermilan merged commit 5fd52fd into main Mar 22, 2024
6 checks passed
@itsjaspermilan itsjaspermilan deleted the hcpie-1016-fix-iam-docs branch March 22, 2024 21:03
catsby added a commit that referenced this pull request Mar 22, 2024
* main:
  updated documentation
  updated CHANGELOG.md
  HCPIE-1016: Adding and adjusting subcategories for IAM stuff (#797)
  updated documentation
  updated CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants